Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Strict types #262

Closed
wants to merge 2 commits into from
Closed

WIP: Strict types #262

wants to merge 2 commits into from

Conversation

dom-nie
Copy link

@dom-nie dom-nie commented Nov 19, 2019

Pull Request (PR) description

Improved typing on variables and made it more strict where necessary.

@dom-nie dom-nie changed the title Strict types WIP: Strict types Nov 19, 2019
@vox-pupuli-tasks
Copy link

Dear @dom-nie, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @dom-nie, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak
Copy link
Member

hi, thaanks for the work. I'm going to close this in favour of #302

@bastelfreak bastelfreak closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants