Allow vhost ssl cert andn key inheritance from http section #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch the SSL cert and key are always configured within vhost server blocks. This is a problem when using a single wildcard certificate operating with multiple virtual host entries because the configuration results in increased memory consumption according to the NGINX documentation: > It is better to place a certificate file with several names and its private key > file at the http level of configuration to inherit their single memory copy in > all servers. This patch addresses the problem by making it possible to pass the boolean value `false` to the ssl_key and ssl_cert parameters. When doing so, the SSL key and certificate will be inherited from the http section of the configuration. References: * http://nginx.org/en/docs/http/configuring_https_servers.html#name_based_https_servers
jeffmccune
force-pushed
the
better_ssl
branch
from
c710892 to
566607a
Compare
|
This seems similar to #794 (though that one is not in working state right now). |
|
thanks @jeffmccune ! |
This was referenced Oct 26, 2016
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Allow vhost ssl cert andn key inheritance from http section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the SSL cert and key are always configured within vhost
server blocks. This is a problem when using a single wildcard certificate
operating with multiple virtual host entries because the configuration results
in increased memory consumption according to the NGINX documentation:
This patch addresses the problem by making it possible to pass the boolean
value
falseto the ssl_key and ssl_cert parameters. When doing so, the SSLkey and certificate will be inherited from the http section of the
configuration.
References: