Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl_cert and ssl_key are required #743

Closed
gerases opened this issue Jan 20, 2016 · 3 comments
Closed

ssl_cert and ssl_key are required #743

gerases opened this issue Jan 20, 2016 · 3 comments
Labels
needs-feedback Further information is requested

Comments

@gerases
Copy link
Contributor

gerases commented Jan 20, 2016

The code below requires ssl_cert and ssl_key to be defined. But I have an include file that defines those instead :( Any way around this?

# Check to see if SSL Certificates are properly defined.
  if ($ssl == true) {
    if ($ssl_cert == undef) or ($ssl_key == undef) {
      fail('nginx: SSL certificate/key (ssl_cert/ssl_key) and/or SSL Private must be defined and exist on the target system(s)')
    }
  }

Also, I think the ability not to specify the ciphers would be nice.

@3flex
Copy link
Contributor

3flex commented Feb 9, 2016

Hmm... we could downgrade to a warning or info message instead of a hard fail.

Just wondering why the include file instead of using these parameters? I'm not blocking this just yet, but I want to understand the use case before changing the existing behaviour which is useful for 99% of our users. Warnings or info messages are more easily missed.

@3flex 3flex added the needs-feedback Further information is requested label Aug 30, 2016
@wyardley
Copy link
Collaborator

#945 now allows keys to have an empty value if set to undef. This has been merged in the most recent release (0.5.0), and should resolve your issue.

@gerases
Copy link
Contributor Author

gerases commented Jun 25, 2017

Awesome, I will stop using my fork now. Thanks much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants