Configurable service name #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +109,7 @@ | |||
| $configtest_enable = false, | |||
| $service_ensure = running, | |||
| $service_restart = '/etc/init.d/nginx configtest && /etc/init.d/nginx restart', | |||
| $service_name = 'nginx', | |||
There was a problem hiding this comment.
I'd prefer an undef here, so that the authoritative source of default stays with the service resource.
There was a problem hiding this comment.
Can do. What about the other parameters being passed through to that class? Change those to undef, move the defaults to the service class?
|
👍 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Configurable service name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #455 and addressed the feedback I'd left.
Closes #455