add configurable service name

[jstaph]

This module works very well with the SCL packaged version of NGINX, but needs just one additional point of change. I've added a few lines to allow for adjustment of the service name.

[3flex]

Looks great! To simplify the change slightly could I ask that the new service_name parameter be added as an additional attribute on the service declaration, instead of as the name of the service? e.g.:

service {'nginx':
  name => $service_name,
  ...
}

Also I'm mindful of what's coming in #453. For this reason can you isolate this change to just a new parameter in service.pp as described? That will still let you configure the name and not conflict with that PR. So just the change to that file, and the spec test updates.

Thanks!

[jstaph]

Ah, I should have had a look at the other PR's first. I think I've captured what you'd like, but I'm very happy to make further adjustments if I haven't. Thanks!

[3flex]

That's no problem, you can't be expected to review every other PR to make sure yours doesn't conflict!

I'm going to hold back a day or two until #453 is finalized to reduce churn there, I hope that's OK. In the meantime please squash your changes down a single commit for merging. Thanks!

[jstaph]

Squashed! It definitely makes sense to wait for #453, I'm in no rush. Thanks!

[3flex]

Hi @jstaph sorry I've let this slide, I had totally forgotten to come back and check this.

I just noticed that while you'd set a value in params.pp it's not referenced anywhere. So you can take that out. Also you should add a $service_name parameter to init.pp and pass that through to the nginx::service class (see around lines 109 & 289 of init.pp in master). You should also rebase before making these changes.

Soon as those changes are done I'll merge. Thanks for the code and sorry for the delay!

[3flex]

FYI I need to merge #516 before you'll see the relevant line (289) in init.pp I mentioned - once Travis passes that PR and I've merged you can rebase on master and you'll see the line I mentioned.

Cheers!

[3flex]

Created a new PR which addresses my comments: #534

[jstaph]

@3flex,

Wow, I completely lost track of time. Many apologies!

Thanks for #534, and again, sorry I was away so long.