Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Debian 10 #1595
Drop Debian 10 #1595
Changes from all commits
f3d1758
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 61 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 93 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 97 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 100 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 106 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 112 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 8
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - AlmaLinux 9
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 9
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 9
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 9
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 8
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - AlmaLinux 8
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - Rocky 9
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 8
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - Rocky 9
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 7 - CentOS 7
Check failure on line 119 in spec/acceptance/nginx_server_spec.rb
GitHub Actions / Puppet / Puppet 8 - CentOS 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look like modern versions. Is there anything that still uses plain
passenger
or can it be simplified to justfacts.dig(:os, 'family') == 'Debian'
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of the broken tests I would adress that in #1596 where all tests will be functional again