Drop Debian 10 #1595
Merged
Drop Debian 10 #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
force-pushed
the
drop_debian_10
branch
2 times, most recently
from
d269f5a to
e2ab88e
Compare
ekohl
requested changes
May 28, 2024
Comment on lines
+193
to
194
| if (facts.dig(:os, 'name') == 'Debian' && %w[11].include?(facts.dig(:os, 'release', 'major'))) || | ||
| (facts.dig(:os, 'name') == 'Ubuntu' && %w[bionic focal jammy].include?(facts.dig(:os, 'distro', 'codename'))) |
There was a problem hiding this comment.
These all look like modern versions. Is there anything that still uses plain passenger or can it be simplified to just facts.dig(:os, 'family') == 'Debian'?
There was a problem hiding this comment.
because of the broken tests I would adress that in #1596 where all tests will be functional again
I started on this one and then figured the failing tests need some more work, given the old ngins version in debian 10 the simplest solution would be to rebase this one on master and then merge it with failing test, then I can fix the tests in #1596 and bump the min version over there |
TheMeier
force-pushed
the
drop_debian_10
branch
2 times, most recently
from
2a447ab to
b32a80f
Compare
there is already breaking changes on master, so next releease will be major test have been broken for a while and will be fixed in voxpupuli#1596
This was referenced May 28, 2024
kenyon
approved these changes
Jun 2, 2024
smortex
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is already breaking changes on master, so next releease will be major
test have been broken for a while and will be fixed in #1596