Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: set package_ensure defaults to installed #1523

Merged
merged 1 commit into from
Dec 1, 2022
Merged

init: set package_ensure defaults to installed #1523

merged 1 commit into from
Dec 1, 2022

Conversation

kenyon
Copy link
Member

@kenyon kenyon commented Dec 1, 2022

For compatibility with puppetlabs/puppetlabs-stdlib#1196.

Fixes #1522.

@puppet-community-rangefinder
Copy link

nginx is a class

Breaking changes to this file WILL impact these 15 modules (exact match):
Breaking changes to this file MAY impact these 33 modules (near match):

This module is declared in 9 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kenyon kenyon mentioned this pull request Dec 1, 2022
Closed
@kenyon kenyon force-pushed the package_ensure_installed branch from 7689aaf to e57d015 Compare December 1, 2022 17:01
@kenyon kenyon force-pushed the package_ensure_installed branch from e57d015 to dc60d08 Compare December 1, 2022 17:31
@kenyon
Copy link
Member Author

kenyon commented Dec 1, 2022

The Puppet 7 Ubuntu 22.04 test failure was just a network timeout. I'll close and reopen to hopefully get a clean run.

@kenyon kenyon closed this Dec 1, 2022
@kenyon kenyon reopened this Dec 1, 2022
@puppet-community-rangefinder
Copy link

nginx is a class

Breaking changes to this file WILL impact these 15 modules (exact match):
Breaking changes to this file MAY impact these 33 modules (near match):

This module is declared in 9 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

smortex
smortex approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smortex smortex added the bug Something isn't working label Dec 1, 2022
@kenyon
Copy link
Member Author

kenyon commented Dec 1, 2022

Now all of the Ubuntu tests failed because of E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/libm/libmaxminddb/libmaxminddb0_1.5.2-1build2_amd64.deb 403 Forbidden [IP: 185.125.190.39 80] 😒

One more retry!

@kenyon kenyon closed this Dec 1, 2022
@kenyon kenyon reopened this Dec 1, 2022
@puppet-community-rangefinder
Copy link

nginx is a class

Breaking changes to this file WILL impact these 15 modules (exact match):
Breaking changes to this file MAY impact these 33 modules (near match):

This module is declared in 9 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kenyon kenyon merged commit acc64e3 into voxpupuli:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default package_ensure value is not compatible with current stdlib default for ensure_packages()
2 participants
@kenyon @smortex