Flip installed and present in Function ensure_packages #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flip "installed" and "present" in Function "ensure_packages". Puppet-Type "package" defaults to "installed" and not to "present" (compare https://github.com/puppetlabs/puppet/blob/main/lib/puppet/type/package.rb#L148). This Misconception lies in the Code since the most early Days. With flipping these two Values, Rspec-Tests do not have to be adapted, when migrating from "package {}" to "ensure_packages()".
adrianiurca
approved these changes
Aug 9, 2021
|
LGTM |
|
Hi Puppet, |
ekohl
changed the title
This may be true, but as Exactly this is my Point: When I have |
|
I don't mind having this merged, I just think it's backwards incompatible and the next stdlib release should be 8.0.0 and not 7.x. |
I'm not entirely sure whether I agree. While functionally it's a change, I think it doesn't really warrant a major version bump because for end users it doesn't change anything. You can argue that the testing method that was linked was checking internal behavior of Another thing that we should consider is that many (most?) Puppet modules use git checkouts so the version number is really irrelevant. Weighing this against the very painful costs for stdlib (so many modules need updating), I don't think we should. That said, I have changed the PR title because it was really not covering the intent of this PR. That makes for an unusable changelog entry. |
kenyon
added a commit
to kenyon/puppet-openssl
that referenced
this pull request
Aug 24, 2021
$package_ensure default needs to be changed due to puppetlabs/puppetlabs-stdlib#1196
kenyon
added a commit
to kenyon/puppet-openssl
that referenced
this pull request
Aug 24, 2021
$package_ensure default needs to be changed due to puppetlabs/puppetlabs-stdlib#1196 Also convert docs to Puppet Strings format.
penguinspiral
added a commit
to penguinspiral/puppet-control-repo
that referenced
this pull request
Aug 26, 2021
As of version 8.0.0 the 'puppetlabs-stdlib' module updated the `ensure_packages` function from 'present' to 'installed': puppetlabs/puppetlabs-stdlib#1196 This commit addresses the single usage of `ensure_packages` function in a dependent component module 'theforeman-dns'. Verification (complete suite): * `pdk test unit` Result: * Finished in 1 minute 3.18 seconds (files took 1.09 seconds to load) 685 examples, 0 failures
kenyon
added a commit
to kenyon/puppet-bind
that referenced
this pull request
Oct 12, 2021
kenyon
added a commit
to kenyon/puppet-ca_cert
that referenced
this pull request
Mar 10, 2022
This allows for better compatibility with puppetlabs-stdlib version 8
and use of ensure_packages('ca-certificates') (such as the
puppet-openssl does) due to
puppetlabs/puppetlabs-stdlib#1196. Otherwise you
can get a duplicate resource declaration error due to the mismatch in
the ensure value.
kenyon
added a commit
to kenyon/puppet-ca_cert
that referenced
this pull request
Mar 10, 2022
This allows for better compatibility with puppetlabs-stdlib version 8
and use of ensure_packages('ca-certificates') (such as the
puppet-openssl does) due to
puppetlabs/puppetlabs-stdlib#1196. Otherwise you
can get a duplicate resource declaration error due to the mismatch in
the ensure value.
pcfens
pushed a commit
to voxpupuli/puppet-ca_cert
that referenced
this pull request
Mar 11, 2022
This allows for better compatibility with puppetlabs-stdlib version 8
and use of ensure_packages('ca-certificates') (such as the
puppet-openssl does) due to
puppetlabs/puppetlabs-stdlib#1196. Otherwise you
can get a duplicate resource declaration error due to the mismatch in
the ensure value.
kenyon
added a commit
to kenyon/puppet-nfs-1
that referenced
this pull request
Mar 11, 2022
This allows for compatibility with stdlib v8 due to puppetlabs/puppetlabs-stdlib#1196.
@ekohl It looks like it breaks all of my actual catalogs. I've just run a catalog-diff against a branch with stdlib 8.2.0 vs 5.2.0 and I've got ~1600 compilation failures. Duplicate declaration of package resources. :( |
|
The following compiled before, and now it doesn't. package { 'tzdata':
ensure => present,
}
ensure_packages(['tzdata']) |
rehanone
added a commit
to rehanone/puppet-autorestic
that referenced
this pull request
Jul 17, 2022
…abs/puppetlabs-stdlib#1196) - Removed test coverage for Ubuntu 14.04.
rehanone
added a commit
to rehanone/puppet-dockctl
that referenced
this pull request
Jul 17, 2022
…abs/puppetlabs-stdlib#1196) - Updated `pdk` template version. - Added unit test coverage for Debian 11. - Removed test coverage for Ubuntu 14.04.
kenyon
added a commit
to kenyon/puppet-nginx
that referenced
this pull request
Dec 1, 2022
For compatibility with puppetlabs/puppetlabs-stdlib#1196. Fixes voxpupuli#1522.
kenyon
added a commit
to kenyon/puppet-nginx
that referenced
this pull request
Dec 1, 2022
For compatibility with puppetlabs/puppetlabs-stdlib#1196. Fixes voxpupuli#1522.
kenyon
added a commit
to kenyon/puppet-nginx
that referenced
this pull request
Dec 1, 2022
For compatibility with puppetlabs/puppetlabs-stdlib#1196. Fixes voxpupuli#1522.
alexjfisher
added a commit
to alexjfisher/puppetlabs-stdlib
that referenced
this pull request
Mar 13, 2023
This unbreaks the breaking change made in puppetlabs#1196 Also refactored to create a separate dispatch method for the case when `packages` is a `Hash`, and having that call the main `ensure_packages` method. This simplifies the code by only ever calling `ensure_resource` instead of calling `ensure_resources` for hashes. Defaulting `default_attributes` to an empty hash instead of `nil` in the method signatures further simplifies the code. Fixes puppetlabs#1252
alexjfisher
added a commit
to alexjfisher/puppetlabs-stdlib
that referenced
this pull request
Mar 13, 2023
This unbreaks the breaking change made in puppetlabs#1196 Also refactored to create a separate dispatch method for the case when `packages` is a `Hash`, and having that call the main `ensure_packages` method. This simplifies the code by only ever calling `ensure_resource` instead of calling `ensure_resources` for hashes. Defaulting `default_attributes` to an empty hash instead of `nil` in the method signatures further simplifies the code. Fixes puppetlabs#1252
alexjfisher
added a commit
to alexjfisher/puppetlabs-stdlib
that referenced
this pull request
Apr 20, 2023
This unbreaks the breaking change made in puppetlabs#1196 Also refactored to create a separate dispatch method for the case when `packages` is a `Hash`, and having that call the main `ensure_packages` method. This simplifies the code by only ever calling `ensure_resource` instead of calling `ensure_resources` for hashes. Defaulting `default_attributes` to an empty hash instead of `nil` in the method signatures further simplifies the code. Fixes puppetlabs#1252
alexjfisher
added a commit
to alexjfisher/puppetlabs-stdlib
that referenced
this pull request
Apr 21, 2023
This unbreaks the breaking change made in puppetlabs#1196 Also refactored to create a separate dispatch method for the case when `packages` is a `Hash`, and having that call the main `ensure_packages` method. This simplifies the code by only ever calling `ensure_resource` instead of calling `ensure_resources` for hashes. Defaulting `default_attributes` to an empty hash instead of `nil` in the method signatures further simplifies the code. Fixes puppetlabs#1252
6 tasks
b4ldr
pushed a commit
to b4ldr/puppetlabs-stdlib
that referenced
this pull request
Jun 22, 2023
This unbreaks the breaking change made in puppetlabs#1196 Also refactored to create a separate dispatch method for the case when `packages` is a `Hash`, and having that call the main `ensure_packages` method. This simplifies the code by only ever calling `ensure_resource` instead of calling `ensure_resources` for hashes. Defaulting `default_attributes` to an empty hash instead of `nil` in the method signatures further simplifies the code. Fixes puppetlabs#1252
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 17, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 17, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 17, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 17, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
rrotter
added a commit
to mlibrary/nebula
that referenced
this pull request
Sep 18, 2023
Flip present to installed in cifs_mount_spec due to puppetlabs/puppetlabs-stdlib#1196
rrotter
added a commit
to mlibrary/nebula
that referenced
this pull request
Sep 18, 2023
Flip present to installed in cifs_mount_spec due to puppetlabs/puppetlabs-stdlib#1196
rrotter
added a commit
to mlibrary/nebula
that referenced
this pull request
Sep 18, 2023
Flip present to installed in cifs_mount_spec due to puppetlabs/puppetlabs-stdlib#1196
rrotter
added a commit
to mlibrary/nebula
that referenced
this pull request
Sep 18, 2023
Flip present to installed in cifs_mount_spec due to: puppetlabs/puppetlabs-stdlib#1196
rrotter
added a commit
to mlibrary/nebula
that referenced
this pull request
Sep 19, 2023
Flip present to installed in cifs_mount_spec due to: puppetlabs/puppetlabs-stdlib#1196
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 19, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
rrotter
added a commit
to mlibrary/nebula
that referenced
this pull request
Sep 19, 2023
Flip present to installed in cifs_mount_spec due to: puppetlabs/puppetlabs-stdlib#1196
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 20, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 21, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
kenyon
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Sep 21, 2023
For compatibility with puppetlabs/puppetlabs-stdlib#1196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flip
installedandpresentin Functionensure_packages.Puppet-Type
packagedefaults toinstalledand not topresent(compare here ).This Misconception lies in the Code since the most early Days.
With flipping these two Values, Rspec-Tests do not have to be adapted, when migrating from
package {}toensure_packages().