New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage libnginx-mod-http-passenger on modern Debian / Ubuntu #1376

Merged

bastelfreak merged 12 commits into voxpupuli:master from smortex:fix-1340

Mar 22, 2020

Member

smortex commented Feb 20, 2020

Pull Request (PR) description

This is a follow-up to #1341 (closed without being merged) which was an attempt to fix #1340. I took the commits in this legacy PR, rebased them on top of master (fixing a bunch of conflicts) and am now fixing the CI.

This Pull Request (PR) fixes the following issues

Fixes #1340

Jonas E. Engell added 8 commits

February 20, 2020 10:06


          Install libnginx-mod-http-passenger on newer systems

5b151d1

On Debian 9 & Ubuntu 18.04 libnginx-mod-http-passenger needs to be
installed instead of passenger according to the installation guide by
passenger. libnginx-mod-http-passenger has a dependency on passenger, so
it will be installed. Without libnginx-mod-http-passenger nginx will not
be able to handle passenger.

Installation guide:
https://www.phusionpassenger.com/docs/tutorials/deploy_to_production/installations/oss/ownserver/ruby/nginx/


          Move passanger package name to params.pp

a69b27a


          Fixed yumrepo name

4f8dad7


          Add data type to passenger_package_name parameter

f7aa24f


          Add passanger_package_name fully to params.pp

6b3e6a7


          s/passanger_package_name/passenger_package_name/

b345a9c


          Inlucde modules-enabled by default on Ubuntu 18.04 and Debian 9

569cb65


          Purge packages between tests

65b3052

puppet-community-rangefinder bot commented Feb 20, 2020

nginx::config is a class

The enclosing module is declared in 11 of 578 indexed public Puppetfiles.

Breaking changes to this file MAY impact these modules (near match):

vshn-uhosting
halyard-boxen
nginx is a class

The enclosing module is declared in 11 of 578 indexed public Puppetfiles.

Breaking changes to this file WILL impact these modules (exact match):

Breaking changes to this file MAY impact these modules (near match):

The enclosing module is declared in 11 of 578 indexed public Puppetfiles.

that may have no external impact to Forge modules.

nginx::package::redhat is a class

The enclosing module is declared in 11 of 578 indexed public Puppetfiles.

that may have no external impact to Forge modules.

nginx::params is a class

The enclosing module is declared in 11 of 578 indexed public Puppetfiles.

Breaking changes to this file MAY impact these modules (near match):

braiins-wordpressnginx

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.


          Replace legacy facts with newer ones

d0b2986

smortex force-pushed the fix-1340 branch from 51a9a92 to 7165bff Compare

February 20, 2020 21:02


          Fix CI on recent Debian/Ubuntu

7560b42

Now that we install the proper package on recent Debian/Ubuntu, check
for the good package in the catalog.

smortex force-pushed the fix-1340 branch from 7165bff to 7560b42 Compare

February 20, 2020 21:03

bastelfreak reviewed

View reviewed changes

manifests/init.pp Show resolved Hide resolved


          Add documentation for $nginx::include_modules_enabled

cb56245

smortex requested a review from bastelfreak

February 26, 2020 05:12

bastelfreak reviewed

View reviewed changes

manifests/init.pp Outdated Show resolved Hide resolved


          Document and do not accept empty string for $nginx::passenger_package…

2547c4d

…_name

smortex requested a review from bastelfreak

March 6, 2020 23:28

Member

bastelfreak commented Mar 8, 2020

I'm not sure if this is a backwards-incompatible release or not. What about those newer Debian versions if they currently try to use the module? Doesn't it work at all? What happens if the module installed the passanger package in the past and now install the new package? Does that work at all?

bastelfreak added the needs-feedback label

Member Author

smortex commented Mar 16, 2020

Back from holidays, sorry for the delay!

The libnginx-mod-http-passenger package depends on the passenger package which was previously including everything. The new package installs the actual nginx shlib and the adequate configuration file.

Per se, the previous behavior is working from the Puppet point of view, but the resulting configuration is not working (because the nginx module is not installed nor configured).

My guess is that this would only require a MINOR version bump: the change is backward compatible but adds support for systems previously unsupported.

Thanks!

bastelfreak approved these changes

View reviewed changes

bastelfreak merged commit dc7644d into voxpupuli:master

dhoppe mentioned this pull request

modulesync 2.12.0 voxpupuli/puppet-unattended_upgrades#153

Merged

Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request


          Merge pull request voxpupuli#1376 from smortex/fix-1340

ebd2c92

Manage libnginx-mod-http-passenger on modern Debian / Ubuntu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels