Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libnginx-mod-http-passenger on newer systems #1341

Closed
wants to merge 8 commits into from
Closed

Install libnginx-mod-http-passenger on newer systems #1341

wants to merge 8 commits into from

Conversation

jengell
Copy link
Contributor

@jengell jengell commented Aug 8, 2019

Pull Request (PR) description

On Debian 9 & Ubuntu 18.04 libnginx-mod-http-passenger needs to be
installed instead of passenger according to the installation guide by
passenger. libnginx-mod-http-passenger has a dependency on passenger, so
it will be installed. Without libnginx-mod-http-passenger nginx will not
be able to handle passenger.

Installation guide:
https://www.phusionpassenger.com/docs/tutorials/deploy_to_production/installations/oss/ownserver/ruby/nginx/

This Pull Request (PR) fixes the following issues

Fixes #1340

On Debian 9 & Ubuntu 18.04 libnginx-mod-http-passenger needs to be
installed instead of passenger according to the installation guide by
passenger. libnginx-mod-http-passenger has a dependency on passenger, so
it will be installed. Without libnginx-mod-http-passenger nginx will not
be able to handle passenger.

Installation guide:
https://www.phusionpassenger.com/docs/tutorials/deploy_to_production/installations/oss/ownserver/ruby/nginx/
manifests/package/debian.pp Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is pretty much what I meant.

@@ -45,7 +46,7 @@
}

if $purge_passenger_repo {
yumrepo { 'passenger':
yumrepo { $passenger_package_name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a yumrepo, not a package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

manifests/package/redhat.pp Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 but adding a data type is a good practice for new parameters.

manifests/init.pp Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures look relevant:

Aug 08 11:54:23 ubuntu1804-64-1 nginx[6688]: nginx: [emerg] unknown directive "passenger_root" in /etc/nginx/conf.d/mod-http-passenger.conf:2

@jengell
Copy link
Contributor Author

jengell commented Aug 9, 2019

I looked in to that error and it seems that nginx-extras package on Ubuntu 18.04 and Debain 9 adds the /etc/nginx/modules-enabled/ and /etc/nginx/modules-available folders to load dynamic modules. The configuration files are include by default in the nginx configuration but not in the one generated by puppet.

It could be solved by adding loading the passenger module using the dynamic_modules parameter for those versions in the tests or by including /etc/nginx/modules-enabled/*.conf by default. But neither options seems like the correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libnginx-mod-http-passenger should be installed instead of passenger
2 participants