Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apt to dependencies in metadata.json #1375

Closed
wants to merge 1 commit into from

Conversation

genebean
Copy link
Contributor

Pull Request (PR) description

Prior to this commit, apt was required in the fixutures but not in metadata.json. Version 7.2.0 was chosen as the lower bounds of the apt module version because that is when Debian 10 support was added.

This Pull Request (PR) fixes the following issues

Fixes #1374

Prior to this commit, apt was required in the fixutures but not in
metadata.json. Version 7.2.0 was chosen as the lower bounds of the apt
module version because that is when Debian 10 support was added.

Fixes voxpupuli#1374
@ekohl
Copy link
Member

ekohl commented Feb 20, 2020

https://github.com/voxpupuli/puppet-nginx#requirements states this as a soft dependency. Not all platforms use apt so this has been a conscious decision.

@genebean
Copy link
Contributor Author

genebean commented Feb 20, 2020

Personally, I’ve never seen another module that didn’t list this module when it was needed. I think omitting it is a mistake unless using nginx on Debian doesn’t require it by default (i.e. it’s include being excluded by the default value of a conditional expression)

Sent with GitHawk

@ekohl
Copy link
Member

ekohl commented Feb 27, 2020

https://puppet.com/docs/puppet/latest/style_guide.html#dependencies states:

Hard dependencies must be declared explicitly in your module’s metadata.json file.
Soft dependencies should be called out in the README.md, and must not be enforced as a hard requirement in your metadata.json. A soft dependency is a dependency that is only required in a specific set of use cases. For an example, see the rabbitmq module.

@genebean
Copy link
Contributor Author

Learned something new today, thanks @ekohl

@genebean genebean closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puppetlabs/apt missing from metadata.json dependencies
2 participants