Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppetlabs/apt missing from metadata.json dependencies #1374

Closed
genebean opened this issue Feb 20, 2020 · 0 comments
Closed

puppetlabs/apt missing from metadata.json dependencies #1374

genebean opened this issue Feb 20, 2020 · 0 comments

Comments

@genebean
Copy link
Contributor

puppet-nginx/manifests/package/debian.pp

Line 35 in be0a031

include 'apt'
pulls in puppetlabs/apt but it is not listed in

puppet-nginx/metadata.json

Lines 10 to 19 in be0a031

"dependencies": [
{
"name": "puppetlabs/concat",
"version_requirement": ">= 4.1.0 < 7.0.0"
},
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 5.0.0 < 7.0.0"
}
],

@genebean genebean mentioned this issue Feb 20, 2020
Closed
genebean added a commit to genebean/puppet-nginx that referenced this issue Feb 20, 2020
@genebean
Add apt to dependencies in metadata.json
9f6d553 
Prior to this commit, apt was required in the fixutures but not in
metadata.json. Version 7.2.0 was chosen as the lower bounds of the apt
module version because that is when Debian 10 support was added.

Fixes voxpupuli#1374
@genebean genebean mentioned this issue Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@genebean