Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed puppet-lint log format based on new puppet-lint v2.3.0 #102

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

pramodhkp
Copy link
Contributor

Changed linenumber to line according to the new puppet-lint version.

Ref: rodjek/puppet-lint#539

@bbatsov
Copy link
Contributor

bbatsov commented Sep 15, 2017

Should we make this compatible with the old and new format?

@pramodhkp
Copy link
Contributor Author

I could add, if it's not too difficult. I'm new to Elisp. Any suggestions?

@rski
Copy link
Member

rski commented Sep 15, 2017

See rodjek/puppet-lint#540

I don't think it's worth keeping it around. Flycheck doesn't use it, the vim plugins I checked last year (syntastic dont remember which else) when i sent the PR to puppet-lint didn't use it either.

@rski
Copy link
Member

rski commented Sep 27, 2017

@pramodhkp the commit message is a bit misleading because linenumber has been in pre-v1.0 puppet-lint. If you amend it to be along the lines of "removed deprecated something" I'll merge it.

@pramodhkp
Copy link
Contributor Author

@rski Please check if the new commit message is good.

@bbatsov
Copy link
Contributor

bbatsov commented Sep 28, 2017

@rski Pro-tip you can set whatever commit message you want on merge when you use squash an merge (this works for a single commit).

@rski rski merged commit e04f041 into voxpupuli:master Sep 28, 2017
@rski
Copy link
Member

rski commented Sep 28, 2017

@bbatsov nice, thanks!

@pramodhkp thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants