Remove formatting with linenumber
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`linenumber` has been deprecated since v1.0.0, which was released in Aug 2014. It is time to remove it. Fixes rodjekGH-539 Signed-off-by: Romanos Skiadas <[email protected]>
zajdee
pushed a commit
to zajdee/arcanist
that referenced
this pull request
Apr 1, 2020
This diff updates ArcanistPuppetLintLinter.php to be compatible with the latest `puppet-lint`. Based on the change made by the `puppet-lint` maintainers in Issue rodjek/puppet-lint#539 and commithttps://github.com/rodjek/puppet-lint/pull/540 the `linenumber` format string is no longer supported. While the issue was already reported in https://secure.phabricator.com/T10038 and https://secure.phabricator.com/T12169 it has never been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linenumberhas been deprecated since v1.0.0, which was released inAug 2014. It is time to remove it.
Fixes GH-539
Signed-off-by: Romanos Skiadas [email protected]