Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Puppet Unknown variable: 'default_su_group'" #82

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Fix "Puppet Unknown variable: 'default_su_group'" #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
$root_group = 'wheel'
$logrotate_bin = '/usr/local/sbin/logrotate'
$conf_params = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mookie- Can it just become $conf_params = {} ? (like in the default case)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexjfisher I thought about that too but it was added with a commit called "Repair tests" (mookie-@13ce41d#diff-2f383a197b1a428561b364755701d60eR12)
To be honest I haven't looked at the tests yet if it's important to be there. I'll check that tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. The current code is broken and this is a definite improvement.

su_group => $default_su_group,
su_group => undef,
}
$base_rules = {
'wtmp' => {
Expand Down