Fix "Puppet Unknown variable: 'default_su_group'" #82
Conversation
The Variable $default_su_group is not there for osfamily Freebsd. Puppet will fail if you have strict variable checking on.
| @@ -9,7 +9,7 @@ | |||
| $root_group = 'wheel' | |||
| $logrotate_bin = '/usr/local/sbin/logrotate' | |||
| $conf_params = { | |||
There was a problem hiding this comment.
@mookie- Can it just become $conf_params = {} ? (like in the default case)
There was a problem hiding this comment.
@alexjfisher I thought about that too but it was added with a commit called "Repair tests" (mookie-@13ce41d#diff-2f383a197b1a428561b364755701d60eR12)
To be honest I haven't looked at the tests yet if it's important to be there. I'll check that tomorrow.
There was a problem hiding this comment.
No worries. The current code is broken and this is a definite improvement.
|
This looks related to #80 @cliff-wakefield Can you advise? |
|
@alexjfisher certainly issue #80 is related, but only in the sense that the logrotate.conf.erb template wouldn't include any 'su' line without the fix I did the pull request for. |
| @@ -9,7 +9,7 @@ | |||
| $root_group = 'wheel' | |||
| $logrotate_bin = '/usr/local/sbin/logrotate' | |||
| $conf_params = { | |||
There was a problem hiding this comment.
No worries. The current code is broken and this is a definite improvement.
The Variable $default_su_group is not there for osfamily Freebsd. Puppet will fail if you have strict variable checking on.