add support for Debian #131
Conversation
| @@ -22,12 +22,12 @@ | |||
| } | |||
| } | |||
| 'Debian': { | |||
| $default_su_user = versioncmp($facts['operatingsystemmajrelease'], '14.00') ? { | |||
| 1 => 'root', | |||
| $default_su_user = $facts['operatingsystem'] ? { | |||
There was a problem hiding this comment.
just as a note in case somebody checks this in the future: This change is fine because we do not support Ubuntu older than 14.04 (versioncmp() used 14.00, not 14.04)
|
@rj667 thanks for the PR. Can you please take a look at the used email address in the commit? It isn't associated with your github account. On which Debian version is this now supposed to work? Can you add them to https://github.com/voxpupuli/puppet-logrotate/blob/master/metadata.json please? |
|
The test assumes that Debian "should contain Logrotate::Conf[/etc/logrotate.conf] with su_user defined and su_group defined" which is not true. |
|
@rj667 can you adjust the tests so it matches the reality? |
|
Where are the tests? I am not familiar with your CI setup. |
|
The spec tests for defined resources are all at https://github.com/voxpupuli/puppet-logrotate/tree/master/spec/defines and the ones for the classes at https://github.com/voxpupuli/puppet-logrotate/tree/master/spec/classes. Some more docs are at https://github.com/voxpupuli/puppet-logrotate/blob/master/.github/CONTRIBUTING.md. Let us know if you have more questions. |
|
Obsoleted by #134 |
Pull Request (PR) description
Tests $facts['operatingsystem'] to tell Ubuntu and Debian apart.
Ubuntu needs 'su root syslog' in /etc/logrotate.conf
Debian does not.
This Pull Request (PR) fixes the following issues
Fixes #114