Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check debian support #114

Closed
bastelfreak opened this issue May 21, 2018 · 2 comments · Fixed by #134
Closed

check debian support #114

bastelfreak opened this issue May 21, 2018 · 2 comments · Fixed by #134
Labels
needs-help Extra attention is needed

Comments

@bastelfreak
Copy link
Member

this module once listed debian 7 in the metadata.json. We removed it because it's EOL. We need to check if recent debian versions work and add them back.

@bastelfreak bastelfreak added the needs-help Extra attention is needed label May 21, 2018
@KeithOBrien-RGA
Copy link

I am using this module for Debian stretch and it is working well.

@rj667
Copy link

rj667 commented Aug 17, 2018

We are using this module on Debian wheezy, jessie, stretch (about 450 machines in total).
That it works on wheezy, jessie and stretch is likely by accident, because the code in params.pp only checks $facts['operatingsystemmajrelease'] against '14.00' to set $default_su_user and $default_su_group to Ubuntu defaults, and Debian value for that fact happens to be lower.

On Debian buster (testing, the next stable) however the value for operatingsystemmajrelease is 'buster/sid' and the versioncmp() goes bust.

The PR replaces the test for operatingsystemmajrelease with one for operatingsystem which does the right thing on Ubuntu as well as Debian, regardless of version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-help Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants