Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not restart Elasticsearch on config change when restart_config_change is set to false #1114

Merged

Conversation

SndR85
Copy link
Contributor

@SndR85 SndR85 commented Mar 3, 2021

This change will fix that Elasticsearch service is not being restarted when restart_config_change is set to false. Without this change Elasticsearch was still restarted on config changes even when restart_config_change was set to false. See also issue #1113

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@crazymind1337
Copy link
Member

@fatmcgav can we have this PR merged and released soon? I dont like to fork the module again for such a tiny issue.

@shamil
Copy link
Contributor

shamil commented Sep 2, 2021

I think #1111 is what's needed, no need to globally notify entire class

@SndR85
Copy link
Contributor Author

SndR85 commented Sep 2, 2021

I think #1111 is what's needed, no need to globally notify entire class

If you use that method then Elasticsearch will never restart after a config change, is it?

Never mind, I see it's notifying the service from each resource in elasticsearch::config only if restart_config_change is set true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants