fix restart_on_change behavior

[bovy89]

restart_on_change parameter is ignored. If config file is modified, the class elasticsearch::config always notify elasticsearch::service and the elasticsearch service is being restarted

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[bovy89]

Author of the following commits did not sign a Contributor Agreement:
ad68b16

Please, read and sign the above mentioned agreement if you want to contribute to this project

done

[crazymind1337]

Works for me. Can we have this released soon?

[shamil]

I've experienced exactly same issue, my several clusters began to restart and caused us short hiccups until all nodes restarted.
@jmlrt @mgreau @fatmcgav @ry-wiz can you please check this, and if possible merge and release a bugfix. The module had several bug fixes merged, but was never released any point release.

[ghoneycutt]

Closing in favor of #1114

[shamil]

@ghoneycutt I think #1114 is too wide, any reason it was merged?
This PR is the proper one in my opinion. Each resource in elasticsearch::config use $_notify_service and based on that it decides if service should be reloaded or not. If #1114 is what you prefer instead, then we need to clean up all the places which have $_notify_service specified.

puppet-elasticsearch/manifests/init.pp

Lines 452 to 456 in b1ab9c2

	# Should we restart Elasticsearch on config change?
	$_notify_service = $elasticsearch::restart_config_change ? {
	true => Service[$elasticsearch::service_name],
	false => undef,
	}