Pin rake version to avoid rubocop/rake 11 incompatibility #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests are failing with: https://travis-ci.org/voxpupuli/puppet-corosync/jobs/114738369 ``` $ bundle exec rake $CHECK rake aborted! NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000000021df220> /home/travis/build/voxpupuli/puppet-corosync/vendor/bundle/ruby/2.2.0/gems/rubocop-0.37.2/lib/rubocop/rake_task.rb:24:in `initialize' /home/travis/build/voxpupuli/puppet-corosync/Rakefile:9:in `new' /home/travis/build/voxpupuli/puppet-corosync/Rakefile:9:in `<top (required)>' (See full trace by running task with --trace) ``` Once rubocop/rubocop#2931 is released then rubocop can be updated and the pinning removed. Thanks to theforeman/foreman#3298 for the pointer
bastelfreak
added a commit
that referenced
this pull request
Mar 9, 2016
Pin rake version to avoid rubocop/rake 11 incompatibility
roidelapluie
added a commit
to voxpupuli/puppet-corosync
that referenced
this pull request
Mar 9, 2016
roidelapluie
added a commit
to voxpupuli/puppet-corosync
that referenced
this pull request
Mar 9, 2016
roidelapluie
added a commit
to voxpupuli/puppet-corosync
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-alternatives
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-archive
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-collectd
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-confluence
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-dotnet
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-extlib
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
This was referenced Mar 9, 2016
roidelapluie
added a commit
to voxpupuli/puppet-gluster
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
This was referenced Mar 9, 2016
roidelapluie
added a commit
to voxpupuli/puppet-jira
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-kafka
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-mcollective
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-amanda
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-mysql_java_connector
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-nodejs
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-rundeck
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
This was referenced Mar 9, 2016
roidelapluie
added a commit
to voxpupuli/puppet-stash
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
roidelapluie
added a commit
to voxpupuli/puppet-unattended_upgrades
that referenced
this pull request
Mar 9, 2016
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
This was referenced Mar 9, 2016
|
Merged three hours ago. |
|
yes and? |
|
Just commenting that a new rubocop is being released today, if the rubocop PR is to be believed. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-archive
that referenced
this pull request
Oct 23, 2017
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
cegeka-jenkins
pushed a commit
to cegeka/puppet-extlib
that referenced
this pull request
Oct 23, 2017
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
elmendalerenda
pushed a commit
to elmendalerenda/puppet-kafka
that referenced
this pull request
Mar 30, 2018
See voxpupuli/modulesync_config#93 This commit updates the module to our latest modulesync configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are failing with:
https://travis-ci.org/voxpupuli/puppet-corosync/jobs/114738369
Once rubocop/rubocop#2931 is released then rubocop can be updated and
the pinning removed.
Thanks to theforeman/foreman#3298 for the pointer