Update to support Rake 11 #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this work on older rakes? |
|
@bbatsov Yes. |
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * Replace Rake::TaskManager#last_comment with Rake::TaskManager#last_description for Rake 1.11 compatibility. ([@tbrisker][]) | |||
There was a problem hiding this comment.
Oops, my mistake. will fix.
tbrisker
changed the title
tbrisker
force-pushed
the
patch-1
branch
2 times, most recently
from
7a00e28 to
cdb80b4
Compare
|
Why not bump Rake to the latest version in the same commit? |
|
@alexdowad will do. Pushing new version with rake ~> 11.0. |
Updated gemfile to newer version of Rake. Rake 11 removed deprecated `last_comment` in favor of `last_description`. See https://github.com/ruby/rake/blob/master/History.rdoc#1100--2016-03-09 for more details.
tbrisker
changed the title
roidelapluie
added a commit
to roidelapluie/modulesync_config
that referenced
this pull request
Mar 9, 2016
All tests are failing with: https://travis-ci.org/voxpupuli/puppet-corosync/jobs/114738369 ``` $ bundle exec rake $CHECK rake aborted! NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000000021df220> /home/travis/build/voxpupuli/puppet-corosync/vendor/bundle/ruby/2.2.0/gems/rubocop-0.37.2/lib/rubocop/rake_task.rb:24:in `initialize' /home/travis/build/voxpupuli/puppet-corosync/Rakefile:9:in `new' /home/travis/build/voxpupuli/puppet-corosync/Rakefile:9:in `<top (required)>' (See full trace by running task with --trace) ``` Once rubocop/rubocop#2931 is released then rubocop can be updated and the pinning removed. Thanks to theforeman/foreman#3298 for the pointer
|
👍 Hopefully this is released soon. |
|
+1 updating/deploying many apps because of a bundler-audit warning is currently failing because of this bug :/ |
|
I'll try to cut a new release later today. |
peterberkenbosch
added a commit
to glossier/solidus_social
that referenced
this pull request
Mar 9, 2016
…ample rubocop (rubocop/rubocop#2931) that will give you this error: ``` MethodError: undefined method `last_comment' for #<Rake::Application ```
cbrunsdon
pushed a commit
to cbrunsdon/solidus_social
that referenced
this pull request
Mar 9, 2016
Temporary workaround for a rubocop issue in rubocop/rubocop#2931 Same patch peter berkenbosch applied to dynamo's spree_social fork Thanks peter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following are checked:
master(if not - rebase it)and description in grammatically correct, complete sentences.
See https://github.com/ruby/rake/blob/master/History.rdoc#1100--2016-03-09