Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use puppet-lint from github #40

Merged
merged 1 commit into from
Dec 6, 2015

Conversation

alexjfisher
Copy link
Member

There hasn't be a release for a long time, but there have been some
fixes since then.

@cyberious
Copy link

My only concern is that how do we determine breaking changes, I think it would be better if we can get @rodjek to ship a new release if one is needed with semvar

@alexjfisher
Copy link
Member Author

A new release would be better, but I'm not expecting one any time soon. :(
rodjek/puppet-lint#401
rodjek/puppet-lint#443

rspec-puppet is set to the latest git version even though there have been new releases of that.
https://github.com/puppet-community/modulesync_config/blob/master/config_defaults.yml#L20

For puppet-lint at least, how about fixing on the latest commit instead? rodjek/puppet-lint@2546fed

@cyberious
Copy link

Commented on it as well, perhaps it is time for PuppetLabs to step up and take over it.

@igalic
Copy link
Contributor

igalic commented Nov 17, 2015

@alexjfisher this needs a rebase now, although, i think it might already be merged in a different pr

There hasn't be a release for a *long* time, but there have been some
fixes since then.
@alexjfisher alexjfisher force-pushed the use_puppet_lint_from_git branch from 57e90e1 to 9e85ef0 Compare November 17, 2015 16:41
@juniorsysadmin
Copy link
Member

👍

igalic added a commit that referenced this pull request Dec 6, 2015
@igalic igalic merged commit e0d9eed into voxpupuli:master Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants