Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a new release! #443

Closed
faxm0dem opened this issue Aug 26, 2015 · 28 comments
Closed

Time for a new release! #443

faxm0dem opened this issue Aug 26, 2015 · 28 comments

Comments

@faxm0dem
Copy link

I stumbled on an issue where my ignored paths were... ignored.
Please prepare a new release, thanks!

@Perdjesk
Copy link

Perdjesk commented Sep 7, 2015

+1 1.1.0...master

A cleaning of issues would be welcomed too. #422 and #417 (maybe?) seem to have been fixed.

@stig
Copy link

stig commented Sep 8, 2015

+1 I am not able to use the arrow_alignment check because of #416, which is fixed in master.

@akerl
Copy link

akerl commented Oct 7, 2015

Bump. Would rock to get a new release cut, I'm running into issues with the linter not checking my files that are fixed on master, as well as config.relative not being settable in the Rakefile

@keithherron
Copy link

+1

2 similar comments
@mterzo
Copy link
Contributor

mterzo commented Oct 29, 2015

+1

@Kriechi
Copy link

Kriechi commented Nov 2, 2015

👍

@cyberious
Copy link

👍 Overdue, if you don't want to maintain perhaps moving it to Puppet-Community or if somebody from PuppetLabs would want to take it over

@walkamongus
Copy link

👍

1 similar comment
@albertux
Copy link

👍

@ghoneycutt
Copy link
Contributor

Use this in your Gemfile to get the latest code.

gem 'puppet-lint', :git => 'https://github.com/rodjek/puppet-lint.git'

@cyberious
Copy link

I would prefer the latest releases in ruby gem and then we can also proxy these through artifactory or pulp instead of pulling from the internet at all times.

@cdenneen
Copy link

👍

@albertux
Copy link

for now use @ghoneycutt solution if you are using Gemfile

if you are installing puppet-lint in your system use:

gem install specific_install
gem specific_install -l https://github.com/rodjek/puppet-lint.git

@alex-harvey-z3q
Copy link

+1

@rnelson0
Copy link
Collaborator

rnelson0 commented May 8, 2016

@rodjek Can you publish a new version of the gem, either 1.2.0 or 2.0.0?

@rmestrum
Copy link

@rodjek Can you please publish a new version of the gem

This was referenced Jun 16, 2016
@rnelson0
Copy link
Collaborator

It looks like we can now release a new gem. The question is, what should the version number be? 1.1.1, 1.2.0, or 2.0.0?

I think there have been too many changes to be a point release, and that there are no backwards incompatible changes but I don't have a full history on the impact of all the changes to be sure of either. I'll start reviewing changes in detail but would like to hear others thoughts as well.

@rnelson0
Copy link
Collaborator

There are also some 71 Issues and 25 pull requests, but a lot of users are pulling from master so I'm confident it could be published as is. If there are any that you believe must be resolved before a new gem is published, please mention them here.

@slm0n87
Copy link

slm0n87 commented Jun 16, 2016

+1

1 similar comment
@albertux
Copy link

+1

@kylog
Copy link
Collaborator

kylog commented Jun 20, 2016

@rnelson0 I agree that this isn't a 1.1.1. As for 1.2.0 vs 2.0.0, I took a scan through what's in master, and the only change that looked possibly to be breaking was #419, e.g. if someone were using --no-80chars-check or PuppetLint.configuration.send("disable_80chars").

Thoughts?

Mostly just psyched that we can release a new gem :)

@rnelson0
Copy link
Collaborator

rnelson0 commented Jun 20, 2016

That reduces the options to:

  1. 1.2.0
  2. 2.0.0

I don't see a way to do voting on GitHub. I am leaning toward 2.0.0 myself. If no-one has any complaints by Wednesday @ 1200 UTC, we'll push out version 2.0.0 to rubygems.

Edit: Thumbs up vote to see 2.0.0 on Wednesday. Thumbs down and a comment to see something else!

@ahpook
Copy link
Collaborator

ahpook commented Jun 20, 2016

@rnelson0 looks good to me, i added a +1 reaction to your post - if people have -1s they can give you a thumbs down!

@daenney
Copy link

daenney commented Jun 21, 2016

I would prefer to see a 2.0.0 that included the necessary Puppet 4 related fixes but I guess that can be another bump. There's a bunch of fixes in master that we can really do with an actual release for.

@rnelson0
Copy link
Collaborator

@daenney I would too, but I think the backlog is pretty large right now and it's best to start the 2.x train then start merging them in as we clear it out.

@rnelson0
Copy link
Collaborator

Puppet-lint v2.0.0 is now available. Happy downloads! https://rubygems.org/gems/puppet-lint/versions/2.0.0

@rnelson0
Copy link
Collaborator

Thank you to everyone for your assistance in getting this release out!

@albertux
Copy link

Thank you @rnelson0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests