Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BKR-1049) update ruby version doc #1352

Merged
merged 4 commits into from
Mar 14, 2017

Conversation

kevpl
Copy link
Contributor

@kevpl kevpl commented Mar 10, 2017

[skip ci]

This PR documents #1329,
and should be merged at the same time as that one is, so that the
change is described as soon as it goes in.

@puppetlabs/beaker, @tvpartytonight what do you think?
I originally thought this requirement would be mentioned in other
places, but I'm having trouble finding any. Am I missing some?

@ferglor
Copy link
Contributor

ferglor commented Mar 13, 2017

👍

@kevpl
Copy link
Contributor Author

kevpl commented Mar 13, 2017

Thanks to web editing, I've added review changes per our discussion earlier today, but they had to come on as their own commits.

@tvpartytonight please take another look, & note that this will need to be squashed when merged.

@tvpartytonight tvpartytonight merged commit 9d59590 into voxpupuli:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants