-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main #4574
Merge main #4574
Conversation
Add Ubuntu 24.04 `fiftyone-db` support
WalkthroughThe recent changes involve enhancing the artifact upload logic in GitHub workflows, refining the HTML template structure for improved readability, and updating the version and MongoDB links in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/build-db.yml (1 hunks)
- docs/source/_templates/layout.html (7 hunks)
- package/db/setup.py (2 hunks)
Files skipped from review due to trivial changes (1)
- docs/source/_templates/layout.html
Additional comments not posted (3)
.github/workflows/build-db.yml (1)
68-78
: Review the conditional artifact upload logic.The changes to the artifact upload logic appear to be well-implemented, with separate conditions for
sdist
and wheels based on the platform. This ensures that the appropriate artifacts are uploaded for each platform, enhancing the specificity and correctness of the build process.package/db/setup.py (2)
146-146
: Version update to "1.1.4" is correctly implemented.The version update from "1.1.3" to "1.1.4" in
setup.py
is correctly implemented and consistent with the documentation and usage within the file.
98-101
: Verify the MongoDB download links for version "24".The links for version "24" are identical to those for version "23". If this duplication is intentional, ensure that it is correct and the links are up-to-date. If not, this may need correction to reflect the specific binaries for version "24".
Verification successful
The MongoDB download links for version "24" are valid and up-to-date.
The URLs provided for version "24" are accessible and correctly point to the intended MongoDB binaries.
https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2204-7.0.4.tgz
https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2204-7.0.4.tgz
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify MongoDB download links for version "24". # Test: Check if links for version "24" are unique or if they should be updated. echo "Check MongoDB download links for version '24' at https://fastdl.mongodb.org/"Length of output: 168
Script:
#!/bin/bash # Description: Verify MongoDB download links for version "24". # URLs to check urls=( "https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2204-7.0.4.tgz" "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2204-7.0.4.tgz" ) # Check each URL for url in "${urls[@]}"; do echo "Checking URL: $url" http_status=$(curl -o /dev/null -s -w "%{http_code}\n" "$url") echo "HTTP Status: $http_status" doneLength of output: 952
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge
main
intodevelop
Summary by CodeRabbit
Documentation
Chores
1.1.3
to1.1.4
and added MongoDB download links for version 24.