-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs script #4556
Add docs script #4556
Conversation
WalkthroughThe changes primarily focus on refining the process of artifact upload, enhancing the documentation layout, and updating the setup for a database package. Specifically, these include filtering specific file types for artifact uploads, improving the HTML structure of the documentation, and updating MongoDB version details in the database setup script. Changes
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/build-db.yml (1 hunks)
- docs/source/_templates/layout.html (7 hunks)
- package/db/setup.py (2 hunks)
Files skipped from review due to trivial changes (1)
- docs/source/_templates/layout.html
Additional comments not posted (3)
.github/workflows/build-db.yml (1)
72-72
: LGTM!The change to refine the artifact upload path to include only
.tar.gz
files for thesdist
platform is appropriate.package/db/setup.py (2)
98-101
: LGTM!The addition of MongoDB version "24" download links for different architectures is consistent and necessary for supporting the new version.
146-146
: LGTM!The version update from "1.1.3" to "1.1.4" is appropriate to reflect the new changes in the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😋
af79459
to
0acdadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
docs/source/_templates/layout.html (1)
2-2
: Addalt
attribute to the meta tag.The meta tag should include an
alt
attribute for accessibility.- <meta property="og:image" content="{{og_image}}" /> + <meta property="og:image" content="{{og_image}}" alt="Open Graph Image" />
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- docs/source/_templates/layout.html (7 hunks)
Additional comments not posted (9)
docs/source/_templates/layout.html (9)
12-12
: Ensure the Clearbit script is necessary and secure.Verify that the Clearbit script is necessary for your documentation and that it doesn't introduce any security vulnerabilities.
44-47
: Verify the correctness of the new links.Ensure the new links in the "Products" section are correct and lead to the intended pages.
57-59
: Verify the correctness of the new links.Ensure the new links in the "Community" section are correct and lead to the intended pages.
73-75
: Verify the correctness of the new links.Ensure the new links in the "About Us" section are correct and lead to the intended pages.
93-94
: Ensure the GitHub star button attributes are correct.Verify that the GitHub star button attributes are correctly set and functional.
98-98
: Ensure the new button is correctly formatted.Verify that the new button for scheduling a workshop is correctly formatted and functional.
192-192
: Ensure the GitHub buttons script is necessary and secure.Verify that the GitHub buttons script is necessary for your documentation and that it doesn't introduce any security vulnerabilities.
195-200
: Ensure the Google Analytics script is necessary and secure.Verify that the Google Analytics script is necessary for your documentation and that it doesn't introduce any security vulnerabilities.
Line range hint
204-238
:
Ensure the BigPicture.io script is necessary and secure.Verify that the BigPicture.io script is necessary for your documentation and that it doesn't introduce any security vulnerabilities.
What changes are proposed in this pull request?
Adds clearbit script to docs
How is this patch tested? If it is not, please explain why.
Docs build
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit
Documentation
Chores
.tar.gz
files.