chore(kiosk-browser): remove uses of non-trivial APIs #5637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refs #4531
Removes all uses of the following
kiosk-browser
APIs:this was restored because we need a way to capture the web rendering area and not the entire screencaptureScreenshot
+saveAs
(replaced withdev-dock/backend
API +gnome-screenshot
)this was restored because we still need to pick election definitionsshowOpenDialog
(selecting election package to load in dev is removed)showSaveDialog
("Save As" in a few places is removed)saveAs
("Save As" in a few places is removed, and writing the screenshot is now done on the backend)kiosk.quit
andkiosk.log
remain unchanged.Demo Video or Screenshot
Edit 11/27: The video below shows the screenshot flow using a
wry
-based version ofkiosk-browser
. This no longer works with the reversion to usingkiosk.captureScreenshot
, but the flow outlined in the video is the same.CleanShot.2024-11-25.at.16.51.12.mp4
Click to view `wry` based app code
Testing Plan
Tested in the original
kiosk-browser
and the new prototypewry
-basedkiosk-browser
(see above). Standard browser usage remains unchanged since it doesn't have these APIs anyway.