Remove most kiosk APIs
#171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use these in `vxsuite`: - `kiosk.saveAs` - `kiosk.showSaveDialog` Also fixes a couple small things: - `kiosk.quit` does not take an exit code - `kiosk.captureScreenshot` should return a `Uint8Array` and not a `Buffer`
They don't provide much value since they really only test `captureScreenshot`, and this whole project is (hopefully) not long for this world.
jonahkagan
approved these changes
Dec 10, 2024
.circleci/config.yml
Outdated
There was a problem hiding this comment.
Do you still think we should remove the integration tests since we're keeping kiosk-browser around for now?
There was a problem hiding this comment.
Good question. I couldn't even get them running locally, so I think their current value isn't awesome. That said, we probably shouldn't kill them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with votingworks/vxsuite#5637. Keeps the
kioskAPIs that vxsuite still needs.