Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Despite outside Docker use, I use Windows, there is a captcha and other error messages. #402

Open
useronegit opened this issue Nov 16, 2024 · 5 comments

Comments

@useronegit
Copy link

I use the bat file, many error messages appear in the console.
The script finds the free games, but the main error message is the captcha.

I made the one claim manually because I thought that if I solved a captcha, it would no longer appear

grafik

grafik

grafik

@vttc08
Copy link

vttc08 commented Nov 18, 2024

This is as excepted. You'll always get epic games captcha on browser automation tools regardless of platform and OS. The only difference on windows native compared to Docker is that you'll actually be able to complete the captcha without error (useful for saving browser data and transfer to docker).

I've suggested to the dev to implement link notification for manual claims and I believe he has done so. On a trusted local browser session, claiming those free games is easy as click the link in notification, click get game and finish.

@floxigen
Copy link

floxigen commented Dec 1, 2024

This is as excepted. You'll always get epic games captcha on browser automation tools regardless of platform and OS. The only difference on windows native compared to Docker is that you'll actually be able to complete the captcha without error (useful for saving browser data and transfer to docker).

I've suggested to the dev to implement link notification for manual claims and I believe he has done so. On a trusted local browser session, claiming those free games is easy as click the link in notification, click get game and finish.

I've seen your comment there #259, but I don't really know what to change in js to see the url in notification.

With vanilla js from vogler i'm not able to see it in discord for sure
Discord_2024-12-01_10-26-12

@vttc08
Copy link

vttc08 commented Dec 2, 2024

Given that vogler closed the PR regarding that, I'd assume he make the change already. And in the updated code, the link to the game was there along with the title, so it should be sent. Maybe the <a> tag is which likely works better in other apprise platform may not work in Discord. I was still using my old formatting for notify so I've been getting notification with links consistently.
https://github.com/vogler/free-games-claimer/blob/c8cf7362fa2ff92386eee4dc847784d95d7f5195/epic-games.js#L274C189-L274C242
This is what I did, in line 274. The url appears in my Discord, maybe you could try that.

          await notify(`epic-games: got captcha challenge right before claim of. Use VNC to solve it manually. \n Game link ${url}`);

image

@floxigen
Copy link

floxigen commented Dec 2, 2024

Thanks I'll try this !

NeoMod added a commit to NeoMod/free-games-claimer that referenced this issue Jan 1, 2025
This fixes the "game link" missing from notification when checking Epic Games Store and encountering a captcha, as per vogler#259 should have been but instead wasn't. Issue was identified in vogler#402 comment by "vttc08" (vogler#402 (comment))

I also added the missing notification for "Game Already in Library" for Epic Games Store, since I felt it is useful because it provides an easy way to know if the script is working or not during scheduled usage.

This also provided the opportunity to check if the game url link was handled properly outside "Discord": I have added a commented option where one could activate the "Already in Library" notification that will also provide the game url link for easy verification.
@NeoMod
Copy link

NeoMod commented Jan 1, 2025

Thank you @vttc08 !

I did take the liberty to try and submit a pull request with the change you have identified (#417) also adding a feature suggestion: the inclusion of a notification in case of "Game already in Library" when executing the Epic Games node. I believe this is useful in receiving a quick "status message" about the script working correctly or not, even when not faced with a captcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants