Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Notifications only or include URL #259

Closed
p6002 opened this issue Nov 24, 2023 · 4 comments
Closed

Epic: Notifications only or include URL #259

p6002 opened this issue Nov 24, 2023 · 4 comments

Comments

@p6002
Copy link

p6002 commented Nov 24, 2023

Could you add an option for notifications only?
It's several times faster for me to manually add a game to my account in my browser than for the software to do it.
Currently I get a notification on gotify that I should go into VNC, log in and the session has already expired, log into docker, restart the container, get the capcha notification again, go in through VNC, fill in the capcha and add the game. After all, it makes no sense.
Maybe it would be better to get only a notification with the game title, and a link to epic to add manually? It will be several times faster.

@vttc08
Copy link

vttc08 commented Nov 30, 2023

I agree, with on mobile and away from server, there is also turning on VPN and navigating captcha on mobile VNC app. It's also a cat and mouse game between Epic and this project on browser detection and as of now in docker installs, the captcha doesn't work. Where with a saved session on mobile/desktop browser, the process is instant with no captcha.

There is a simple step to get notification only. Just edit one line in epic-games.js, change the 'catpcha challenge ...' part with url without quotations, this will send a notification with the epic game store url and you can add the game manually. The js file is location in the /fgc folder of the container. However, the change will not persist in new container update unless the developer add the change to the new image.

image

@vogler
Copy link
Owner

vogler commented Dec 18, 2023

@p6002 Yea, doesn't make sense to use it like that if you get captchas.

@vttc08 Good idea, I'll add the link.

@vogler vogler closed this as completed in 76597f4 Dec 19, 2023
@vogler
Copy link
Owner

vogler commented Dec 19, 2023

Let me know if there are problems or if you propose some different message.

@vogler vogler changed the title Notifications only. Epic: Notifications only or include URL Dec 19, 2023
NeoMod added a commit to NeoMod/free-games-claimer that referenced this issue Jan 1, 2025
This fixes the "game link" missing from notification when checking Epic Games Store and encountering a captcha, as per vogler#259 should have been but instead wasn't. Issue was identified in vogler#402 comment by "vttc08" (vogler#402 (comment))

I also added the missing notification for "Game Already in Library" for Epic Games Store, since I felt it is useful because it provides an easy way to know if the script is working or not during scheduled usage.

This also provided the opportunity to check if the game url link was handled properly outside "Discord": I have added a commented option where one could activate the "Already in Library" notification that will also provide the game url link for easy verification.
@NeoMod
Copy link

NeoMod commented Jan 1, 2025

Just to leave a note for completeness: as per #402 (comment) the included format for the "game url link" is not working.

The Game link ${url} code works perfectly with Apprise (tested with NTFY) as per vttc08 suggestion.

I did take the liberty to forward a merge request integrating this fix; I left this comment here just in case someone else lands on this topic searching the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants