-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Notifications only or include URL #259
Comments
I agree, with on mobile and away from server, there is also turning on VPN and navigating captcha on mobile VNC app. It's also a cat and mouse game between Epic and this project on browser detection and as of now in docker installs, the captcha doesn't work. Where with a saved session on mobile/desktop browser, the process is instant with no captcha. There is a simple step to get notification only. Just edit one line in epic-games.js, change the |
Let me know if there are problems or if you propose some different message. |
This fixes the "game link" missing from notification when checking Epic Games Store and encountering a captcha, as per vogler#259 should have been but instead wasn't. Issue was identified in vogler#402 comment by "vttc08" (vogler#402 (comment)) I also added the missing notification for "Game Already in Library" for Epic Games Store, since I felt it is useful because it provides an easy way to know if the script is working or not during scheduled usage. This also provided the opportunity to check if the game url link was handled properly outside "Discord": I have added a commented option where one could activate the "Already in Library" notification that will also provide the game url link for easy verification.
Just to leave a note for completeness: as per #402 (comment) the included format for the "game url link" is not working. The I did take the liberty to forward a merge request integrating this fix; I left this comment here just in case someone else lands on this topic searching the issue. |
Could you add an option for notifications only?
It's several times faster for me to manually add a game to my account in my browser than for the software to do it.
Currently I get a notification on gotify that I should go into VNC, log in and the session has already expired, log into docker, restart the container, get the capcha notification again, go in through VNC, fill in the capcha and add the game. After all, it makes no sense.
Maybe it would be better to get only a notification with the game title, and a link to epic to add manually? It will be several times faster.
The text was updated successfully, but these errors were encountered: