[CAFV-217] Support TKG 1.6.1 vm creation with CPI 1.4 common core #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "Add Ovdc check when getting ovdc network" (vmware#399) Signed-off-by: ymo24 <[email protected]>
…m crashing … (vmware#372) * Update common core to commit bf93908 to prevent CAPVCD from crashing when using IP Spaces Signed-off-by: lzichong <[email protected]> * Update externalIP param to take empty string as vcdmachine will not update VS IP Signed-off-by: lzichong <[email protected]> * Concluded on externalIp param input, added additional comments Signed-off-by: lzichong <[email protected]> * Update ticket to CAPVCD Board Signed-off-by: lzichong <[email protected]> * Include CAFV ticket in other TODO comment Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: lzichong <[email protected]>
…ation (vmware#402) Signed-off-by: ymo24 <[email protected]>
Signed-off-by: ltimothy7 <[email protected]>
Signed-off-by: ltimothy7 <[email protected]>
Signed-off-by: ltimothy7 <[email protected]>
Signed-off-by: ltimothy7 <[email protected]>
lzichong
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Reviewed 1 of 3 files at r3, 8 of 923 files at r4, 5 of 5 files at r5, all commit messages.
Reviewable status: 14 of 930 files reviewed, all discussions resolved
ymo24
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 14 of 930 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes proposed in this Pull Request
Checklist
API Changes
Are there API changes?
Issue
If applicable, please reference the relevant issue
Fixes #
This change is