[CAFV-125] Update common core to commit bf93908 to prevent CAPVCD from crashing … #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when using IP Spaces Signed-off-by: lzichong <[email protected]>
Anirudh9794
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Reviewed 2 of 7 files at r1, all commit messages.
Reviewable status: 2 of 7 files reviewed, all discussions resolved (waiting on @arunmk)
…pdate VS IP Signed-off-by: lzichong <[email protected]>
Signed-off-by: lzichong <[email protected]>
Anirudh9794
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 3 of 7 files reviewed, all discussions resolved (waiting on @arunmk)
arunmk
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Reviewed 5 of 7 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @Anirudh9794)
Signed-off-by: lzichong <[email protected]>
Signed-off-by: lzichong <[email protected]>
ltimothy7
pushed a commit
to ltimothy7/cluster-api-provider-cloud-director
that referenced
this pull request
Apr 5, 2023
…m crashing … (vmware#372) * Update common core to commit bf93908 to prevent CAPVCD from crashing when using IP Spaces Signed-off-by: lzichong <[email protected]> * Update externalIP param to take empty string as vcdmachine will not update VS IP Signed-off-by: lzichong <[email protected]> * Concluded on externalIp param input, added additional comments Signed-off-by: lzichong <[email protected]> * Update ticket to CAPVCD Board Signed-off-by: lzichong <[email protected]> * Include CAFV ticket in other TODO comment Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: lzichong <[email protected]>
Anirudh9794
pushed a commit
that referenced
this pull request
Apr 10, 2023
* [CAFV-171] [common-core] sync with CPI common-core (a1a149d80f32) for "Add Ovdc check when getting ovdc network" (#399) Signed-off-by: ymo24 <[email protected]> * [CAFV-125] Update common core to commit bf93908 to prevent CAPVCD from crashing … (#372) * Update common core to commit bf93908 to prevent CAPVCD from crashing when using IP Spaces Signed-off-by: lzichong <[email protected]> * Update externalIP param to take empty string as vcdmachine will not update VS IP Signed-off-by: lzichong <[email protected]> * Concluded on externalIp param input, added additional comments Signed-off-by: lzichong <[email protected]> * Update ticket to CAPVCD Board Signed-off-by: lzichong <[email protected]> * Include CAFV ticket in other TODO comment Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: lzichong <[email protected]> * [CAFV-177] Ensure CAPVCD Controller accepts RDE 1.1.0 for cluster creation (#402) Signed-off-by: ymo24 <[email protected]> * update to common core cpi 1.4 Signed-off-by: ltimothy7 <[email protected]> * calling tkg new vm function (#382) Signed-off-by: ltimothy7 <[email protected]> * added tkg 1.6.1 crs test files (#388) Signed-off-by: ltimothy7 <[email protected]> * added crs and antrea template (#390) Signed-off-by: ltimothy7 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]> Signed-off-by: lzichong <[email protected]> Signed-off-by: ltimothy7 <[email protected]> Co-authored-by: ymo24 <[email protected]> Co-authored-by: lzichong <[email protected]>
Anirudh9794
pushed a commit
that referenced
this pull request
Apr 11, 2023
…m crashing … (#372) * Update common core to commit bf93908 to prevent CAPVCD from crashing when using IP Spaces Signed-off-by: lzichong <[email protected]> * Update externalIP param to take empty string as vcdmachine will not update VS IP Signed-off-by: lzichong <[email protected]> * Concluded on externalIp param input, added additional comments Signed-off-by: lzichong <[email protected]> * Update ticket to CAPVCD Board Signed-off-by: lzichong <[email protected]> * Include CAFV ticket in other TODO comment Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: lzichong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when using IP Spaces
Signed-off-by: lzichong [email protected]
Description
Please provide a brief description of the changes proposed in this Pull Request
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml?./infrastructure-vcd/v1.0.0/?Issue
If applicable, please reference the relevant issue
Fixes #
This change is