Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VCDA-4852] update ci file with missing packages #411

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

abaruni
Copy link
Contributor

@abaruni abaruni commented Mar 7, 2023

Description

Please provide a brief description of the changes proposed in this Pull Request

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @abaruni)

Copy link
Contributor

@ymo24 ymo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @abaruni)

@abaruni abaruni merged commit 4922459 into vmware:main Mar 8, 2023
lzichong added a commit that referenced this pull request Apr 11, 2023
#424)

* feat: add cluster class support (#357)

- create a VCDClusterTemplate object
- update controllers with required changes
- update infrastructure templates

* make rde type consistent (#403)

Signed-off-by: ymo24 <[email protected]>

* [CAFV-156] Revert addition of v1beta2 fields in v1beta1 VCDMachineSpec (#397)

* remove ExtraOvdcNetworks & VmNamingTemplate fields from v1beta1.VCDMachineSpec and update conversions

* make ExtraOvdcNetworks a pointer to make it truly optional

* regenerate after rebase

* outputting etcd and coredns versions (#404)

Signed-off-by: ltimothy7 <[email protected]>

* [CAFV-181] Testfest - Add omitempty for extraOvdcNetworks to avoid null when empty (#405)

* Add omitempty for extraOvdcNetworks to avoid null when empty

Signed-off-by: lzichong <[email protected]>

* Remove pointer type and keep it as a generic slice of string

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>

* fix: fields in example resources (#314)

* fix: update webhook server secret name (#407)

- This MR updates the webhook server cert secret name from webhook-server-cert to
  capvcd-webhook-server-cert to avoid other controllers Certificate overwriting the
  CAPVCD certificate. webhook-server-cert is very common name and it is default secret
  name of any operator created using kubebuilder.

  This is a problem when multiple controller built using kubebuilder are deployed in the
  namespace.

* Fix deepy copy for in.ExtraOvdcNetworks (#406)

* update ci file with missing packages (#411)

* [CAFV-27], [CAFV-180] Add CSI, CPI qualified versions for CAPVCD 1.0.0, CAPVCD main-branch & update TKG BOM link in CLUSTERCTL README (#409)

* Add CSI, CPI supported versions for CAPVCD 1.0.0, CAPVCD  main-branch

Signed-off-by: lzichong <[email protected]>

* CAFV-180: Update CLUSTERCTL README link to refer to TKG BOM in Workload cluster README

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>

* [CAFV-182] Remove unneeded config values and management label (#408)

* removed vsphere and management references and other unneded values

Signed-off-by: ltimothy7 <[email protected]>

* reverted antrea

Signed-off-by: ltimothy7 <[email protected]>

* removed oidc, nsxt, and tkg values

Signed-off-by: ltimothy7 <[email protected]>

---------

Signed-off-by: ltimothy7 <[email protected]>

* Add bom.json and dependencies.txt to capvcd-manifest-airgapped image (#412)

Add bom.json and dependencies.txt to capvcd-manifest-airgapped image

---------

Signed-off-by: Aritra Sen <[email protected]>

* common core sync with safe ovdc name access (#416)

Signed-off-by: ltimothy7 <[email protected]>

* [CAFV-195] Updates the capvcdCluster schema apiVersion to 1.1 (#413)

Signed-off-by: sayloo <[email protected]>

* [CAFV-175] Create developer guide for CAPVCD API Upgrade (#410)

* add developer build

Signed-off-by: ymo24 <[email protected]>

* minor update

Signed-off-by: ymo24 <[email protected]>

* address comments

Signed-off-by: ymo24 <[email protected]>

* [CAFV-175] address comments

Signed-off-by: ymo24 <[email protected]>

* minor fix

Signed-off-by: ymo24 <[email protected]>

* remove all the details

Signed-off-by: ymo24 <[email protected]>

* minor fix

Signed-off-by: ymo24 <[email protected]>

* update comments

Signed-off-by: ymo24 <[email protected]>

* address comments

Signed-off-by: ymo24 <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>

* [CAFV-159] update v1beta2 capvcd objects in template files and example files (#417)

* [CAFV-159] update v1beta2 capvcd objects in cluster-class-template.yaml

Signed-off-by: ymo24 <[email protected]>

* [CAFV-159] update cluster-class-template.yaml and capi-quickstart.yaml

Signed-off-by: ymo24 <[email protected]>

* [CAFV-159] update all the template files

Signed-off-by: ymo24 <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>

* Cleanup Makefile and DockerFile to use release/version for prod builds and release/version-gitsha for dev builds (#418)

Currently the capvcd dev images are tagged with release/version-gitsha and prod images are tagged with release/version string. However the version string stored in the binary is alway release/version.

In this PR, we have cleaned up the Makefile and Dockerfile to ensure that proper version strings are set on the binary too.

Signed-off-by: Aritra Sen <[email protected]

* Update on manifest template files: migrate from k8s.gcr.io to registry.k8s.io (#415)

Signed-off-by: Waleed Malik <[email protected]>

* [CAFV-200] Update manifests generated to point to projects.registry.vmware.com (#422)

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>
Signed-off-by: ltimothy7 <[email protected]>
Signed-off-by: lzichong <[email protected]>
Signed-off-by: Aritra Sen <[email protected]>
Signed-off-by: sayloo <[email protected]>
Signed-off-by: Aritra Sen <[email protected]
Signed-off-by: Waleed Malik <[email protected]>
Co-authored-by: Vivek Kumar Singh <[email protected]>
Co-authored-by: ymo24 <[email protected]>
Co-authored-by: Adnan Baruni <[email protected]>
Co-authored-by: ltimothy7 <[email protected]>
Co-authored-by: Erkan Erol <[email protected]>
Co-authored-by: rocknes <[email protected]>
Co-authored-by: Sahithi Ayloo <[email protected]>
Co-authored-by: Waleed Malik <[email protected]>
lzichong pushed a commit that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants