feat: add cluster class support #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksyngh
force-pushed
the
cluster-class-support
branch
2 times, most recently
from
97c6e50 to
253d5c3
Compare
viveksyngh
force-pushed
the
cluster-class-support
branch
from
253d5c3 to
c470a8e
Compare
arunmk
approved these changes
Jan 26, 2023
viveksyngh
force-pushed
the
cluster-class-support
branch
4 times, most recently
from
3e5300d to
03aeb50
Compare
sahithi
approved these changes
Feb 24, 2023
viveksyngh
force-pushed
the
cluster-class-support
branch
from
03aeb50 to
cceb875
Compare
- create a VCDClusterTemplate object - update controllers with required changes - update infrastructure templates
viveksyngh
force-pushed
the
cluster-class-support
branch
from
cceb875 to
4285d66
Compare
lzichong
added a commit
that referenced
this pull request
Apr 11, 2023
#424) * feat: add cluster class support (#357) - create a VCDClusterTemplate object - update controllers with required changes - update infrastructure templates * make rde type consistent (#403) Signed-off-by: ymo24 <[email protected]> * [CAFV-156] Revert addition of v1beta2 fields in v1beta1 VCDMachineSpec (#397) * remove ExtraOvdcNetworks & VmNamingTemplate fields from v1beta1.VCDMachineSpec and update conversions * make ExtraOvdcNetworks a pointer to make it truly optional * regenerate after rebase * outputting etcd and coredns versions (#404) Signed-off-by: ltimothy7 <[email protected]> * [CAFV-181] Testfest - Add omitempty for extraOvdcNetworks to avoid null when empty (#405) * Add omitempty for extraOvdcNetworks to avoid null when empty Signed-off-by: lzichong <[email protected]> * Remove pointer type and keep it as a generic slice of string Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: lzichong <[email protected]> * fix: fields in example resources (#314) * fix: update webhook server secret name (#407) - This MR updates the webhook server cert secret name from webhook-server-cert to capvcd-webhook-server-cert to avoid other controllers Certificate overwriting the CAPVCD certificate. webhook-server-cert is very common name and it is default secret name of any operator created using kubebuilder. This is a problem when multiple controller built using kubebuilder are deployed in the namespace. * Fix deepy copy for in.ExtraOvdcNetworks (#406) * update ci file with missing packages (#411) * [CAFV-27], [CAFV-180] Add CSI, CPI qualified versions for CAPVCD 1.0.0, CAPVCD main-branch & update TKG BOM link in CLUSTERCTL README (#409) * Add CSI, CPI supported versions for CAPVCD 1.0.0, CAPVCD main-branch Signed-off-by: lzichong <[email protected]> * CAFV-180: Update CLUSTERCTL README link to refer to TKG BOM in Workload cluster README Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: lzichong <[email protected]> * [CAFV-182] Remove unneeded config values and management label (#408) * removed vsphere and management references and other unneded values Signed-off-by: ltimothy7 <[email protected]> * reverted antrea Signed-off-by: ltimothy7 <[email protected]> * removed oidc, nsxt, and tkg values Signed-off-by: ltimothy7 <[email protected]> --------- Signed-off-by: ltimothy7 <[email protected]> * Add bom.json and dependencies.txt to capvcd-manifest-airgapped image (#412) Add bom.json and dependencies.txt to capvcd-manifest-airgapped image --------- Signed-off-by: Aritra Sen <[email protected]> * common core sync with safe ovdc name access (#416) Signed-off-by: ltimothy7 <[email protected]> * [CAFV-195] Updates the capvcdCluster schema apiVersion to 1.1 (#413) Signed-off-by: sayloo <[email protected]> * [CAFV-175] Create developer guide for CAPVCD API Upgrade (#410) * add developer build Signed-off-by: ymo24 <[email protected]> * minor update Signed-off-by: ymo24 <[email protected]> * address comments Signed-off-by: ymo24 <[email protected]> * [CAFV-175] address comments Signed-off-by: ymo24 <[email protected]> * minor fix Signed-off-by: ymo24 <[email protected]> * remove all the details Signed-off-by: ymo24 <[email protected]> * minor fix Signed-off-by: ymo24 <[email protected]> * update comments Signed-off-by: ymo24 <[email protected]> * address comments Signed-off-by: ymo24 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]> * [CAFV-159] update v1beta2 capvcd objects in template files and example files (#417) * [CAFV-159] update v1beta2 capvcd objects in cluster-class-template.yaml Signed-off-by: ymo24 <[email protected]> * [CAFV-159] update cluster-class-template.yaml and capi-quickstart.yaml Signed-off-by: ymo24 <[email protected]> * [CAFV-159] update all the template files Signed-off-by: ymo24 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]> * Cleanup Makefile and DockerFile to use release/version for prod builds and release/version-gitsha for dev builds (#418) Currently the capvcd dev images are tagged with release/version-gitsha and prod images are tagged with release/version string. However the version string stored in the binary is alway release/version. In this PR, we have cleaned up the Makefile and Dockerfile to ensure that proper version strings are set on the binary too. Signed-off-by: Aritra Sen <[email protected] * Update on manifest template files: migrate from k8s.gcr.io to registry.k8s.io (#415) Signed-off-by: Waleed Malik <[email protected]> * [CAFV-200] Update manifests generated to point to projects.registry.vmware.com (#422) Signed-off-by: lzichong <[email protected]> --------- Signed-off-by: ymo24 <[email protected]> Signed-off-by: ltimothy7 <[email protected]> Signed-off-by: lzichong <[email protected]> Signed-off-by: Aritra Sen <[email protected]> Signed-off-by: sayloo <[email protected]> Signed-off-by: Aritra Sen <[email protected] Signed-off-by: Waleed Malik <[email protected]> Co-authored-by: Vivek Kumar Singh <[email protected]> Co-authored-by: ymo24 <[email protected]> Co-authored-by: Adnan Baruni <[email protected]> Co-authored-by: ltimothy7 <[email protected]> Co-authored-by: Erkan Erol <[email protected]> Co-authored-by: rocknes <[email protected]> Co-authored-by: Sahithi Ayloo <[email protected]> Co-authored-by: Waleed Malik <[email protected]>
lzichong
pushed a commit
that referenced
this pull request
Apr 20, 2023
- create a VCDClusterTemplate object - update controllers with required changes - update infrastructure templates
ymo24
pushed a commit
to ymo24/cluster-api-provider-cloud-director
that referenced
this pull request
Aug 28, 2023
- create a VCDClusterTemplate object - update controllers with required changes - update infrastructure templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes proposed in this Pull Request
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml?./infrastructure-vcd/v1.0.0/?Issue
If applicable, please reference the relevant issue
Fixes #
This change is