Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VCDA-3475] Fix refresh token issue with system admin when username is not provided #119

Merged
merged 2 commits into from
May 2, 2022
Merged

[VCDA-3475] Fix refresh token issue with system admin when username is not provided #119

merged 2 commits into from
May 2, 2022

Conversation

Anirudh9794
Copy link
Contributor

@Anirudh9794 Anirudh9794 commented Apr 28, 2022 •
edited by goelaashima
Loading

  • when authenticating using refresh token, follow the following steps
  • authenticate as a system org user
  • if the above step fails, authenticate as a tenant user
  • this PR also fixes authentication based tests which were broken

This change is Reviewable

@Anirudh9794
[VCDA-3475] fix authentication issue with system admin refresh tokens…
d9ec534 
… by implementing fallback (vmware#116)

* Implement fallback approach to authenticate with refresh token as system org user

Signed-off-by: Aniruddha Shamasundar <[email protected]>

* Fix authentication test cases in CAPVCD

Signed-off-by: Aniruddha Shamasundar <[email protected]>

* deleted accidentally committed file

Signed-off-by: Aniruddha Shamasundar <[email protected]>

* Address review comment

Signed-off-by: Aniruddha Shamasundar <[email protected]>
(cherry picked from commit d08db02)
@Anirudh9794
formatting changes
f4a3adf 
Signed-off-by: Aniruddha Shamasundar <[email protected]>
@Anirudh9794 Anirudh9794 requested review from sahithi and arunmk April 28, 2022 16:35
arunmk
arunmk approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks for doing this

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sahithi)

sahithi
sahithi approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@sahithi sahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Anirudh9794)

@Anirudh9794 Anirudh9794 merged commit 9e3257a into vmware:0.5.x May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunmk arunmk arunmk approved these changes

@sahithi sahithi sahithi approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anirudh9794 @sahithi @arunmk @vmwclabot