[VCDA-3475] fix authentication issue with system admin refresh tokens by implementing fallback

[Anirudh9794]

• when authenticating using refresh token, follow the following steps

• authenticate as a system org user

• if the above step fails, authenticate as a tenant user

• this PR also fixes authentication based tests which were broken

---

This change is 

[arunmk]

Reviewed 9 of 9 files at r1.
Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @Anirudh9794, @arunmk, and @sahithi)

---

pkg/config/cloudconfig.go line 124 at r1 (raw file):

		return nil, fmt.Errorf("Unable to decode yaml file: [%v]", err)
	}
	//config.VCD.Host = strings.TrimRight(config.VCD.Host, "/")

why is this commented out?

---

pkg/vcdcapiclient/defined_entity.go line 1 at r1 (raw file):

package vcdcapiclient

I am guessing this is extra content?

[Anirudh9794]

Reviewable status: 6 of 9 files reviewed, 2 unresolved discussions (waiting on @Anirudh9794, @arunmk, and @sahithi)

---

pkg/config/cloudconfig.go line 124 at r1 (raw file):

Previously, arunmk (Arun M. Krishnakumar) wrote…

why is this commented out?

I missed removing this line before sending out the PR. Will remove the line

[Anirudh9794]

pkg/vcdcapiclient/defined_entity.go line 1 at r1 (raw file):

Previously, arunmk (Arun M. Krishnakumar) wrote…

I am guessing this is extra content?

Yes, I deleted this file

[sahithi]

Reviewable status: 6 of 9 files reviewed, 3 unresolved discussions (waiting on @Anirudh9794 and @arunmk)

---

pkg/vcdclient/auth.go line 51 at r3 (raw file):

		// NOTE: for a system admin user using refresh token, the userOrg will still be tenant org.
		// try setting authentication as a system org user
		err = vcdClient.SetToken("system",

Shouldn't the order be another way around? First, attempt with the tenant org and then use the system.

regardless, it shouldn't matter.

[sahithi]

This code will go to common CPI, right?

Reviewable status: 6 of 9 files reviewed, 3 unresolved discussions (waiting on @Anirudh9794 and @arunmk)

[Anirudh9794]

This is already in CPI common library.

[Anirudh9794]

Reviewable status: 6 of 9 files reviewed, 3 unresolved discussions (waiting on @arunmk and @sahithi)

---

pkg/vcdclient/auth.go line 51 at r3 (raw file):

Previously, sahithi (Sahithi Ayloo) wrote…

Shouldn't the order be another way around? First, attempt with the tenant org and then use the system.

regardless, it shouldn't matter.

Done