Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move UpdatePVXStatusToFailed to controller pkg #5840

Merged

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Feb 7, 2023

Realign main with feedback from #5830

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago sseago added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 7, 2023
@sseago sseago closed this Feb 7, 2023
@sseago sseago reopened this Feb 7, 2023
@github-actions github-actions bot requested a review from sseago February 7, 2023 15:45
@codecov-commenter
Copy link

Codecov Report

Merging #5840 (3be7c33) into main (53c3f4b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5840      +/-   ##
==========================================
- Coverage   40.78%   40.75%   -0.03%     
==========================================
  Files         247      247              
  Lines       21492    21506      +14     
==========================================
  Hits         8765     8765              
- Misses      12093    12107      +14     
  Partials      634      634              
Impacted Files Coverage Δ
pkg/cmd/cli/nodeagent/server.go 12.72% <0.00%> (ø)
pkg/controller/pod_volume_backup_controller.go 38.74% <0.00%> (-1.48%) ⬇️
pkg/controller/pod_volume_restore_controller.go 25.00% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reasonerjt reasonerjt requested a review from Lyndon-Li February 13, 2023 05:55
@Lyndon-Li Lyndon-Li merged commit 44bcc09 into vmware-tanzu:main Feb 13, 2023
@Lyndon-Li
Copy link
Contributor

Thanks for this PR @kaovilai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants