Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.10: Use updated PVB/PVR for patching Failed Phase during startup #5830

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Feb 3, 2023

Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

same as #5828 for release-1.10

Fix #5827

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Use the same pvb/pvr update functions across pkg/controller and pkg/cli/nodeagent for consistency of behavior

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai changed the title release-1.9: Use updated PVB/PVR for patching Failed Phase during startup release-1.10: Use updated PVB/PVR for patching Failed Phase during startup Feb 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5830 (dc2f127) into release-1.10 (948b379) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           release-1.10    #5830   +/-   ##
=============================================
  Coverage         40.85%   40.85%           
=============================================
  Files               239      239           
  Lines             20663    20650   -13     
=============================================
- Hits               8442     8437    -5     
+ Misses            11604    11596    -8     
  Partials            617      617           
Impacted Files Coverage Δ
pkg/cmd/cli/nodeagent/server.go 12.72% <0.00%> (+0.22%) ⬆️
pkg/controller/pod_volume_backup_controller.go 40.21% <0.00%> (+1.06%) ⬆️
pkg/controller/pod_volume_restore_controller.go 25.94% <0.00%> (+0.54%) ⬆️
pkg/uploader/provider/kopia.go 52.84% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sseago
sseago previously approved these changes Feb 6, 2023
@kaovilai kaovilai force-pushed the pvb-pvr-should-fail-during-startup-release-1.10 branch from b512cd6 to 820fe8a Compare February 7, 2023 15:21
@Lyndon-Li Lyndon-Li merged commit 1e015ec into vmware-tanzu:release-1.10 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants