Repo Ensurer Refactor #5308
Merged
Repo Ensurer Refactor #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
requested review from
reasonerjt,
ywk253100,
qiuming-best and
blackpiglet
Lyndon-Li
force-pushed
the
repository-ensurer-refactor
branch
from
6418a20 to
9325b53
Compare
blackpiglet
previously approved these changes
Sep 7, 2022
ywk253100
reviewed
Sep 8, 2022
Lyndon-Li
force-pushed
the
repository-ensurer-refactor
branch
from
9325b53 to
f711708
Compare
Lyndon-Li
force-pushed
the
repository-ensurer-refactor
branch
2 times, most recently
from
cd5441a to
13a3963
Compare
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
repository-ensurer-refactor
branch
from
13a3963 to
8496b43
Compare
ywk253100
approved these changes
Sep 8, 2022
blackpiglet
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the repoEnsurer code to use controller runtime client and wrap some common BackupRepository operations to share with other modules.
Fixes #5024