Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ResticRepositoryEnsurer controller with kubebuilder #5024

Closed
blackpiglet opened this issue Jun 19, 2022 · 2 comments · Fixed by #5308
Closed

Refactor ResticRepositoryEnsurer controller with kubebuilder #5024

blackpiglet opened this issue Jun 19, 2022 · 2 comments · Fixed by #5308

Comments

@blackpiglet
Copy link
Contributor

Describe the problem/challenge you have
[A description of the current limitation/problem/challenge that you are experiencing.]
A sub task of epic #2597 to refactor ResticRepositoryEnsurer controller with kubebuilder.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

@Lyndon-Li
The Ensurer is not really controller but a utility. What we need is just replace the client to use the one from controller-runtime.

@reasonerjt reasonerjt removed the 1.10-candidate The label used for 1.10 planning discussion. label Jun 28, 2022
@reasonerjt reasonerjt added this to the 1.10 milestone Jun 28, 2022
@Lyndon-Li
Copy link
Contributor

Fixed by #5308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants