Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Restic Repository resource/controller to the Kubebuilder framework #4670

Closed
reasonerjt opened this issue Feb 21, 2022 · 2 comments
Closed
Assignees
Milestone

Comments

@reasonerjt
Copy link
Contributor

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@blackpiglet
Copy link
Contributor

Talked with Ming, found there's another piece of code also watches ResticRepository CRD.
https://github.com/vmware-tanzu/velero/blob/main/pkg/restic/repository_ensurer.go#L58-L99

I think this issue is good enough to not include that part, but may need to refactor repository ensurer's list-watch code in another issue.

@blackpiglet
Copy link
Contributor

ResticRepositoryEnsurer related converting to kubebuilder work is traced by #5024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants