-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin/clientmgmt and framework refactoring for BackupItemAction v1 #5271
Conversation
Note that this PR depends on #5263 That commit is included in this PR branch, but once it's merged and this PR is rebased, it won't be in this PR. |
2042650
to
4f17506
Compare
Codecov Report
@@ Coverage Diff @@
## main #5271 +/- ##
==========================================
- Coverage 40.69% 40.67% -0.03%
==========================================
Files 233 233
Lines 20097 20121 +24
==========================================
+ Hits 8179 8184 +5
- Misses 11321 11338 +17
- Partials 597 599 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Initial backup and restore testing with this PR and BIA/RIA plugins (internal BIA/RIAs as well as the openshift plugins installed with OADP) has been successful. (v1) plugins are called just as before, with a plugin image built without any of the versioning-oriented plugin changes. |
Updated to refactor plugin/framework as well. Tested this with backup/restore plugin images which do not import the new code. |
73cdbfe
to
65d9835
Compare
65d9835
to
baf8f0d
Compare
baf8f0d
to
7f65d0a
Compare
Refactors the clientmgmt package to implement the plugin versioning changes needed for BIA v1 and overall package refactoring to support plugin versions in different packages. This should be all that's needed to move on to v2 for BackupItemAction. The remaining plugin types still need similar refactoring to what's being done here for BIA before attempting a v2 implementation. Signed-off-by: Scott Seago <[email protected]>
Refactors the framework package to implement the plugin versioning changes needed for BIA v1 and overall package refactoring to support plugin versions in different packages. This should be all that's needed to move on to v2 for BackupItemAction. The remaining plugin types still need similar refactoring to what's being done here for BIA before attempting a v2 implementation. Signed-off-by: Scott Seago <[email protected]>
7f65d0a
to
e3e2a8d
Compare
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.