Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/clientmgmt and framework refactoring for BackupItemAction v1 #5271

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Aug 31, 2022

Thank you for contributing to Velero!

Please add a summary of your change

Refactors the clientmgmt and framework packages to implement the plugin versioning changes
needed for BIA v1 and overall package refactoring to support plugin versions
in different packages. This should be all that's needed to move on to
v2 for BackupItemAction. The remaining plugin types still need similar
refactoring to what's being done here for BIA before attempting a
v2 implementation.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago
Copy link
Collaborator Author

sseago commented Aug 31, 2022

Note that this PR depends on #5263

That commit is included in this PR branch, but once it's merged and this PR is rebased, it won't be in this PR.

@sseago sseago force-pushed the plugin-versioning-impl branch 2 times, most recently from 2042650 to 4f17506 Compare August 31, 2022 18:30
@codecov-commenter
Copy link

Codecov Report

Merging #5271 (4f17506) into main (94a9a7c) will decrease coverage by 0.02%.
The diff coverage is 63.85%.

@@            Coverage Diff             @@
##             main    #5271      +/-   ##
==========================================
- Coverage   40.69%   40.67%   -0.03%     
==========================================
  Files         233      233              
  Lines       20097    20121      +24     
==========================================
+ Hits         8179     8184       +5     
- Misses      11321    11338      +17     
- Partials      597      599       +2     
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.65% <0.00%> (ø)
pkg/plugin/clientmgmt/process/client_builder.go 94.28% <ø> (ø)
pkg/plugin/clientmgmt/process/logrus_adapter.go 17.56% <ø> (ø)
...g/plugin/clientmgmt/process/restartable_process.go 0.00% <0.00%> (ø)
pkg/plugin/framework/backup_item_action.go 0.00% <ø> (ø)
pkg/plugin/framework/backup_item_action_client.go 0.00% <ø> (ø)
pkg/plugin/framework/backup_item_action_server.go 51.94% <ø> (ø)
pkg/plugin/clientmgmt/process/registry.go 27.69% <14.28%> (ø)
...kupitemaction/v1/restartable_backup_item_action.go 82.50% <58.82%> (ø)
pkg/plugin/clientmgmt/manager.go 80.00% <81.25%> (-1.33%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sseago
Copy link
Collaborator Author

sseago commented Aug 31, 2022

Initial backup and restore testing with this PR and BIA/RIA plugins (internal BIA/RIAs as well as the openshift plugins installed with OADP) has been successful. (v1) plugins are called just as before, with a plugin image built without any of the versioning-oriented plugin changes.

@sseago sseago changed the title plugin/clientmgmt refactoring for BackupItemAction v1 plugin/clientmgmt and framework refactoring for BackupItemAction v1 Sep 1, 2022
@sseago
Copy link
Collaborator Author

sseago commented Sep 1, 2022

Updated to refactor plugin/framework as well. Tested this with backup/restore plugin images which do not import the new code.

@sseago sseago force-pushed the plugin-versioning-impl branch 2 times, most recently from 73cdbfe to 65d9835 Compare September 1, 2022 19:41
@sseago sseago force-pushed the plugin-versioning-impl branch from 65d9835 to baf8f0d Compare September 3, 2022 18:07
@sseago sseago mentioned this pull request Sep 3, 2022
2 tasks
@reasonerjt reasonerjt requested review from blackpiglet and removed request for qiuming-best September 5, 2022 06:34
@sseago sseago force-pushed the plugin-versioning-impl branch from baf8f0d to 7f65d0a Compare September 5, 2022 20:06
@github-actions github-actions bot added the Area/Design Design Documents label Sep 5, 2022
Refactors the clientmgmt package to implement the plugin versioning changes
needed for BIA v1 and overall package refactoring to support plugin versions
in different packages. This should be all that's needed to move on to
v2 for BackupItemAction. The remaining plugin types still need similar
refactoring to what's being done here for BIA before attempting a
v2 implementation.

Signed-off-by: Scott Seago <[email protected]>
Refactors the framework  package to implement the plugin versioning changes
needed for BIA v1 and overall package refactoring to support plugin versions
in different packages. This should be all that's needed to move on to
v2 for BackupItemAction. The remaining plugin types still need similar
refactoring to what's being done here for BIA before attempting a
v2 implementation.

Signed-off-by: Scott Seago <[email protected]>
@sseago sseago force-pushed the plugin-versioning-impl branch from 7f65d0a to e3e2a8d Compare September 15, 2022 15:17
@github-actions github-actions bot removed the Area/Design Design Documents label Sep 15, 2022
@blackpiglet blackpiglet merged commit e42352b into vmware-tanzu:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants