Don't move velero v1 plugins to new proto dir #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-pampattiwar
previously approved these changes
Aug 30, 2022
This was referenced Aug 31, 2022
|
@sseago thanks for the fix! I think this change is a good improvement, could you please also update the section in the design https://github.com/vmware-tanzu/velero/blob/main/design/plugin-versioning.md#proto-service-definitions, to clarify that for backward compatibility the v1 files will be remained in |
To preserve backwards compatibility, don't move velero v1 plugins to new proto dir. Signed-off-by: Scott Seago <[email protected]>
sseago
force-pushed
the
biav1-refactor
branch
from
79056b0 to
b15c59b
Compare
|
@reasonerjt doc updated with the change. |
shubham-pampattiwar
approved these changes
Sep 12, 2022
|
Looks good, thanks for putting this up |
|
Important fix, lets get this in. |
blackpiglet
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Seago [email protected]
Thank you for contributing to Velero!
To preserve backwards compatibility, don't move velero
v1 plugins to new proto dir.
Does your change fix a particular issue?
Fixes #5262
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.