fix: source is valid and fully-qualified url #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source. Closes: vmware-tanzu#523 Signed-off-by: Michael Gasch <[email protected]>
gabo1208
approved these changes
Jun 22, 2023
|
/cherry-pick release-1.10 |
gabo1208
pushed a commit
that referenced
this pull request
Jun 26, 2023
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source. Closes: #523 Signed-off-by: Michael Gasch <[email protected]>
gabo1208
pushed a commit
that referenced
this pull request
Jun 26, 2023
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source. Closes: #523 Signed-off-by: Michael Gasch <[email protected]>
gabo1208
added a commit
that referenced
this pull request
Jun 26, 2023
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source. Closes: #523 Signed-off-by: Michael Gasch <[email protected]> Co-authored-by: Michael Gasch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source.
Fixes #523
Proposed Changes
Sourcevalid and fully-qualified URLPre-review Checklist
Release Note