Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Source should use different method call #523

Closed
embano1 opened this issue Jun 21, 2023 · 0 comments · Fixed by #524
Closed

Event Source should use different method call #523

embano1 opened this issue Jun 21, 2023 · 0 comments · Fixed by #524

Comments

@embano1
Copy link
Contributor

embano1 commented Jun 21, 2023

To construct the event source field (not sure if it's used for other stuff), the code is using source := vClient.URL().Host whereas it should be using vc.client.URL().String() not only to be consistent with VEBA but also to construct a valid URL.

https://github.com/vmware-tanzu/sources-for-knative/blob/8fda92aa2260cdcd276a4314fa631c9356d5e303/pkg/vsphere/adapter.go#LL76C2-L76C30
embano1 added a commit to embano1/sources-for-knative that referenced this issue Jun 22, 2023
@embano1
fix: source is valid and fully-qualified url
51dff10 
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source.

Closes: vmware-tanzu#523
Signed-off-by: Michael Gasch <[email protected]>
@embano1 embano1 mentioned this issue Jun 22, 2023
Merged
3 tasks
gabo1208 pushed a commit that referenced this issue Jun 26, 2023
@embano1 @gabo1208
fix: source is valid and fully-qualified url (#524)
6aede78 
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source.

Closes: #523

Signed-off-by: Michael Gasch <[email protected]>
gabo1208 pushed a commit that referenced this issue Jun 26, 2023
@embano1 @gabo1208
fix: source is valid and fully-qualified url (#524)
b7e3887 
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source.

Closes: #523

Signed-off-by: Michael Gasch <[email protected]>
gabo1208 added a commit that referenced this issue Jun 26, 2023
@gabo1208 @embano1
fix: source is valid and fully-qualified url (#524) (#525)
053feda 
The source property of the adapter was set using the URL host field which is incomplete and confusing for users migrating from the VEBA project to Sources. This fix changes the source semantic to be a valid and fully-qualifed URL of the configured vCenter event source.

Closes: #523

Signed-off-by: Michael Gasch <[email protected]>
Co-authored-by: Michael Gasch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: source is valid and fully-qualified url embano1/sources-for-knative
1 participant
@embano1