feat: add lib.rs with gated child crates #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for Wasm Workers Consumers to depend on the toplevel WWS crate as a library, gating different features behind cargo features.
|
Although I have not yet opened the PR for the containerd-wasm-shims project, the change as a consumer looks like this: deislabs/containerd-wasm-shims@main...ereslibre:wws-toplevel-lib-rs If this gets merged, that PR can be opened with minor modifications (e.g. the branch to pull wws from) |
This was referenced Jul 19, 2023
Angelmmiguel
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for Wasm Workers Consumers to depend on the toplevel WWS crate as a library, gating different features behind cargo features.
The cargo features that will permeate in the toplevel
lib.rsdepend on the usage that third parties will make of our API and I think is worth adding as needed.This change keeps the ability for third parties to consume explicit subcrates if they want. However, if they consume more than one subcrate, when they bump the WWS version, they will need to do so in different places in their
Cargo.toml. This toplevellib.rshelps in this regard, by allowing a consumer to depend on the toplevellib.rs, and only activate the features they need through Cargo features.