Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use more descriptive types for enabling features on serve #185

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat: use more descriptive types for enabling features on serve #185

merged 1 commit into from
Aug 30, 2023

Conversation

ereslibre
Copy link
Contributor

@ereslibre ereslibre commented Jul 20, 2023 •
edited
Loading

This adds more descriptive types to enable/disable features such as the panel on the public API serve() function. With this change, consumers such as the containerd-wasm-shims will be more clear on the intent of their arguments.

ereslibre
ereslibre commented Jul 20, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@ereslibre ereslibre marked this pull request as draft August 23, 2023 14:55
@ereslibre ereslibre force-pushed the panel-enabled-enum branch 5 times, most recently from 21ef21e to cafbe43 Compare August 28, 2023 11:50
@ereslibre ereslibre marked this pull request as ready for review August 28, 2023 11:50
@ereslibre ereslibre requested a review from a team August 28, 2023 11:50
@ereslibre ereslibre force-pushed the panel-enabled-enum branch 3 times, most recently from f89784f to ce60065 Compare August 28, 2023 12:37
@Angelmmiguel Angelmmiguel mentioned this pull request Aug 28, 2023
Merged
@ereslibre ereslibre force-pushed the panel-enabled-enum branch 2 times, most recently from f91360e to 64a2bec Compare August 29, 2023 08:46
@Angelmmiguel Angelmmiguel added this to the v1.5.0 milestone Aug 29, 2023
@Angelmmiguel Angelmmiguel added the 🚀 enhancement New feature or request label Aug 29, 2023
Angelmmiguel
Angelmmiguel reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general! I'm glad to see we're providing a better interface to set the different options! Added some comments 😄

crates/router/src/lib.rs Show resolved Hide resolved
crates/router/src/route.rs Outdated Show resolved Hide resolved
crates/server/src/lib.rs Show resolved Hide resolved
crates/server/src/lib.rs Show resolved Hide resolved
crates/server/src/lib.rs Show resolved Hide resolved
Angelmmiguel
Angelmmiguel approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@ereslibre ereslibre merged commit 6c1a273 into vmware-labs:main Aug 30, 2023
@ereslibre ereslibre deleted the panel-enabled-enum branch August 30, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angelmmiguel Angelmmiguel Angelmmiguel approved these changes

Assignees
No one assigned
Labels
cla-not-required 🚀 enhancement New feature or request
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ereslibre @Angelmmiguel @vmwclabot