Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Add a DeployedCondition for the VirtualMachine object #82

Closed
wants to merge 1 commit into from
Closed

Add a DeployedCondition for the VirtualMachine object #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/v1alpha1/condition_consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ const (
VirtualMachineImageNotFoundReason = "VirtualMachineImageNotFound"
)

const (
// DeployedCondition exposes the deployment status of a VirtualMachine on the infrastructure provider.
DeployedCondition ConditionType = "Deployed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what this means. The VM hardware deployed successfully? The virtual hardware failed? The guest customization succeeded / failed? Both? I am not sure this makes sense as-is. Let's revisit this a bit more. I don't know that aggregate conditions make sense, and we already have a guest customization condition, so is deploy separate or a superset?

Copy link
Contributor Author

@sreyasn sreyasn Aug 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy is separate, It's synonymous to Created/Create in VM operator.

guest customization is triggered in our Update path after Create/Deploy passes.

Copy link
Contributor

@akutz akutz Aug 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy is separate, It's synonymous to Created/Create in VM operator.

The issue is that "deploy" is vague enough to be taken multiple ways. Plus, conditions exist as a way to be more distinct than allowed by a top-level status field such as phase. So let's come up with a better word than deployed as it seems to generic and could be mistaken to mean guest customization as well.

FWIW, here is the latest community discussion around the purpose of conditions.


// DeployFailedReason (Severity=Error) documents that the deployment of the VirtualMachine was not successful.
DeployFailedReason = "DeployFailed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

)

const (
// GuestCustomizationCondition exposes the status of guest customization from within the guest OS, when available.
GuestCustomizationCondition ConditionType = "GuestCustomization"
Expand Down